feat(tts): add consonantEmphasis control for expressive unvoiced segments#693
feat(tts): add consonantEmphasis control for expressive unvoiced segments#693ford442 wants to merge 3 commits into
Conversation
…ents - Expose consonantEmphasis knob in SamplerPanel (bank-level) - Add per-step control in NoteSelector - Wire parameter through AudioEngine → SingingVoice → rubberband-processor - Adjust gain on plosives/fricatives using sliceGain multiplier - Update agent_plan.md and changelog Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
More reviews will be available in 46 minutes and 55 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (76)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…, audioPlayback, and useAppState - Resolved TypeScript strict binding errors on NoteSelector.tsx keys by adding 'pan' support. - Fixed undefined pan defaults in audioPlayback.ts for drums when processing stereo panner nodes. - Resolved undeclared missing consonantEmphasis properties in useAudioEngine interface destructurings. Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
…nagement
💡 What: Added `tabIndex={-1}` to the root `<div role="dialog">`.
🎯 Why: Required for programmatic focus management so that tools like `useFocusTrap` can properly shift focus to the modal wrapper when it mounts.
♿ Accessibility: Ensures that screen readers correctly announce the dialog when it opens, and prevents focus from leaking or failing to trap properly upon initialization.
Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
1 participant
PR created automatically by Jules for task 16489905252920548260 started by @ford442