Fix lossy HTML escape in all modules - #3231
Merged
lubber-de merged 10 commits intoMar 26, 2025
Merged
Conversation
auto-assign
Bot
requested review from
ColinFrick,
ko2in,
lubber-de,
prudho and
y0hami
March 26, 2025 21:12
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lubber-de
reviewed
Mar 26, 2025
mvorisek
force-pushed
the
always_encode_preservehtml_false
branch
from
March 26, 2025 21:25
01e2a73 to
d57df08
Compare
lubber-de
reviewed
Mar 26, 2025
mvorisek
force-pushed
the
always_encode_preservehtml_false
branch
from
March 26, 2025 21:38
d57df08 to
1407047
Compare
lubber-de
added
type/bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as discussed in #3205 (comment)
The first 2 commits fix #3224.
The remaining commits are relanding postponed 8590c21. I checked all
escape(usages in each module. Text like&should be always encoded into&as the meaning is to encode the input and the input is never from innerHTML.