HTML escape should accept only string and null - #3223
Closed
mvorisek wants to merge 4 commits into
Closed
Conversation
Contributor
Author
|
This PR addresses #3222 (comment). Refs:
This behaviour is sadly caused by https://github.com/jquery/jquery/blob/3.7.1/src/data.js#L24-L47. This is impossible to be fully fixed in Fomantic-UI JS without patching jQuery on the page load (prior any jQuery operations). See related atk4/ui#2274 / atk4/ui@45d47a9. |
mvorisek
force-pushed
the
escape_strict_string
branch
from
March 19, 2025 12:02
cf7db60 to
f833e4c
Compare
mvorisek
force-pushed
the
escape_strict_string
branch
from
March 26, 2025 22:39
f833e4c to
531d655
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3222 fixes missing
number.replacefunction well, butnulltype is converted to"null".""is mostly wanted to be displayed instead.undefinedis converted to"undefined". But mostundefinedcases are handled explicitly and values passed usingsetting.someValueshould always be defined. Thus do not have to handle this case in general.Casting
objectorarraytypes usingString()is bad and should never be done.