Use "CSS.escape()" for building dynamic CSS selectors - #3218
Merged
Conversation
mvorisek
changed the title
mvorisek
marked this pull request as ready for review
March 16, 2025 00:06
auto-assign
Bot
requested review from
ColinFrick,
ko2in,
lubber-de,
prudho and
y0hami
March 16, 2025 00:06
mvorisek
changed the title
Member
|
Please resolve conflicts, as i just merged #2584 |
Contributor
Author
|
rebased |
lubber-de
reviewed
Mar 16, 2025
lubber-de
added
type/feat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #3205
Values in CSS selectors should never be dequoted (this is lossy operation), but instead of escaped using native CSS.escape(). This is described in https://developer.mozilla.org/en-US/docs/Web/API/CSS/escape_static#in_context_uses.
Under normal usage this PR should imply no function change.