Skip to content

fix(dropdown) Changed "slide down" transition to "slide" - #2777

Closed
krpatel5657 wants to merge 1 commit into
fomantic:developfrom
krpatel5657:develop
Closed

fix(dropdown) Changed "slide down" transition to "slide"#2777
krpatel5657 wants to merge 1 commit into
fomantic:developfrom
krpatel5657:develop

Conversation

@krpatel5657

Copy link
Copy Markdown

Description

Previously, dropdown menus would close behind other form elements if the two were vertically located next to each other. The fix changes the default transition for dropdown menus when opening or closing to be the "slide" method, instead of "slide down." This results in the dropdown menu closing on top of other form elements. Also, there was an error with dropdown menus that open upwards, as shown in the gifs below. These menus would then slide even further up to close, instead of collapsing down on the form field. The change to the "slide" transition also fixed this issue, again as shown by the gifs.

Testcase

https://jsfiddle.net/krpatel5657/hqe1pnu5/4/

Screenshot (if possible)

Original issue:
dropdown_wrong
Fix:
drop-down-working

Simultaneous fix with upwards dropdown menus:
Original error:
drop-up-notworking
Fix:
drop-up-working

Closes

#2663

@auto-assign
auto-assign Bot requested review from ColinFrick, ko2in, lubber-de and prudho May 7, 2023 21:56
@krpatel5657 krpatel5657 changed the title src/definitions/modules/dropdown.js Changed "slide down" transition to "slide" dropdown.js Changed "slide down" transition to "slide" May 7, 2023
@krpatel5657 krpatel5657 changed the title dropdown.js Changed "slide down" transition to "slide" fix(dropdown) Changed "slide down" transition to "slide" May 8, 2023
@ko2in

ko2in commented May 10, 2023

Copy link
Copy Markdown
Member

Your PR introduces the new issue. When you open the dropdown, it overlaps by the next following menu item until it's fully opened.

fui-pull-2777

I don't think this issue relates to dropdown module alone, but transition module also.

@lubber-de

Copy link
Copy Markdown
Member

Your change does only "heal the wounds", but the real reason for the issue is a double hide transition which messes up both (underlaying menu and upward hiding)
I fixed that by #2818 and will close this PR

@lubber-de lubber-de closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants