fix(dropdown) Changed "slide down" transition to "slide" - #2777
Closed
krpatel5657 wants to merge 1 commit into
Closed
fix(dropdown) Changed "slide down" transition to "slide"#2777krpatel5657 wants to merge 1 commit into
krpatel5657 wants to merge 1 commit into
Conversation
Member
Member
|
Your change does only "heal the wounds", but the real reason for the issue is a double hide transition which messes up both (underlaying menu and upward hiding) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Previously, dropdown menus would close behind other form elements if the two were vertically located next to each other. The fix changes the default transition for dropdown menus when opening or closing to be the "slide" method, instead of "slide down." This results in the dropdown menu closing on top of other form elements. Also, there was an error with dropdown menus that open upwards, as shown in the gifs below. These menus would then slide even further up to close, instead of collapsing down on the form field. The change to the "slide" transition also fixed this issue, again as shown by the gifs.
Testcase
https://jsfiddle.net/krpatel5657/hqe1pnu5/4/
Screenshot (if possible)
Original issue:


Fix:
Simultaneous fix with upwards dropdown menus:


Original error:
Fix:
Closes
#2663