fix(picker): preserve previewed randomized colorscheme state on confirm#2759
Open
AlexanderGolys wants to merge 2 commits intofolke:mainfrom
Open
fix(picker): preserve previewed randomized colorscheme state on confirm#2759AlexanderGolys wants to merge 2 commits intofolke:mainfrom
AlexanderGolys wants to merge 2 commits intofolke:mainfrom
Conversation
AlexanderGolys
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The colorscheme picker preview already applies the selected colorscheme.
For randomized colorschemes like
randomhue, applying:colorschemeagain on confirm can produce a different result than the one shown in
preview.
This changes the confirm path to keep the previewed state instead of
reapplying the colorscheme.
Repro
Snacks.picker.colorschemes()randomhueVerification
randomhueRegular deterministic colorschemes continue to behave the same.