Skip to content

fix(cache purge): ensure cache URL path ends with a trailing slash #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alaminfirdows merged 2 commits into from
Jul 9, 2025
Merged

fix(cache purge): ensure cache URL path ends with a trailing slash #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9be24f8
fix(cache purge): ensure cache URL path ends with a trailing slash
ma-04 May 8, 2025
d98ef64
chore:Using suggested coding standard
ma-04 Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions includes/Fastcgi_Cache.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
public function __construct() {
add_action( 'save_post', [ $this, 'on_save_post' ], 10, 2 );
add_action( 'delete_post', [ $this, 'wp_trash_post' ], 10, 2 );
// add_action( 'edited_term', [ $this, 'purge_taxonomy_cache' ], 10, 2 );

Check warning on line 26 in includes/Fastcgi_Cache.php

View workflow job for this annotation

GitHub Actions / Run PHPCS inspection 

This comment is 58% valid code; is this commented out code?
// add_action( 'wp_update_nav_menu', [ $this, 'purge_home_cache' ], 10, 2 );
}

Expand Down Expand Up @@ -61,7 +61,7 @@
'enabled' => true,
'home_created' => true,
'home_deleted' => true,
// 'single_modified' => true,

Check warning on line 64 in includes/Fastcgi_Cache.php

View workflow job for this annotation

GitHub Actions / Run PHPCS inspection 

This comment is 58% valid code; is this commented out code?
// 'single_comment' => true,
];

Expand Down Expand Up @@ -121,6 +121,11 @@
$parsed = wp_parse_url( $url );
$path = isset( $parsed['path'] ) ? $parsed['path'] : '';

// Ensure path ends with trailing slash
if ( substr( $path, -1 ) !== '/' ) {
$path .= '/';
}

// cache key format (without space): $protocal $method $host $path
// because of nginx-proxy, all request will be http, so we don't need to check protocal
// $method is always GET as we only cache GET request
Expand Down