Repository navigation
Fix invalid postRenderers change causing release to report Ready - #1609
Merged
Merged
Conversation
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
Drop the observed generation guard from the post-renderers and common metadata digest checks. A terminal error after exhausted upgrade retries advances status.observedGeneration, so the next reconcile skipped the check and reported the rolled-back release as Ready while it still ran the previous post-renderers. The guard only prevented an upgrade loop when the digests were recorded at the end of the atomic release. They are now recorded right after a successful install or upgrade. Compare using the algorithm of the observed digest, so changing --snapshot-digest-algo does not trigger upgrades. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com> Assisted-by: claude-code/claude-opus-5-5
stefanprodan
force-pushed
the
fix-post-render
branch
from
October 25, 2026 14:29
24bf1a4 to
616c9dd
Compare
stefanprodan
approved these changes
Oct 25, 2026
Member
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1607