feat(PLAY-1452): add core.options translation key - #111
Merged
Conversation
Add an `options` key to core translations so the options/settings button has a localized label outside the cc namespace. Reuses the existing cc.options wording for the 5 languages that had it (de, en, gr, hi, zh) and adds native translations for the other 15 languages. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maximzavadskiy
changed the title
There was a problem hiding this comment.
Pull request overview
Adds a new core.options translation key so the options/settings control can be labeled outside the cc namespace (supporting the UI redesign work).
Changes:
- Extended
CoreTranslationswith an optionaloptionskey. - Added
core.optionstranslations across many locales (reusing existing wording where available).
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Adds CoreTranslations.options to support a core-level options/settings label. |
| src/languages/cs.ts | Adds core.options translation. |
| src/languages/de.ts | Adds core.options translation. |
| src/languages/en.ts | Adds core.options translation. |
| src/languages/es.ts | Adds core.options translation. |
| src/languages/fi.ts | Adds core.options translation. |
| src/languages/fr.ts | Adds core.options translation. |
| src/languages/gr.ts | Adds core.options translation. |
| src/languages/he.ts | Adds core.options translation. |
| src/languages/hi.ts | Adds core.options translation. |
| src/languages/nb.ts | Adds core.options translation. |
| src/languages/nl.ts | Adds core.options translation. |
| src/languages/nn.ts | Adds core.options translation. |
| src/languages/oc.ts | Adds core.options translation. |
| src/languages/pl.ts | Adds core.options translation. |
| src/languages/pt.ts | Adds core.options translation. |
| src/languages/sk.ts | Adds core.options translation. |
| src/languages/sv.ts | Adds core.options translation. |
| src/languages/tlh.ts | Adds core.options translation. |
| src/languages/tr.ts | Adds core.options translation. |
| src/languages/zh.ts | Adds core.options translation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bbbo
reviewed
Jun 30, 2026
| unmute: "Ton ein", | ||
| volume: "Lautstärke" | ||
| volume: "Lautstärke", | ||
| options: "Optionen" |
bbbo
requested changes
Jun 30, 2026
bbbo
left a comment
bbbo
left a comment
Member
There was a problem hiding this comment.
LGTM except German for options could be "Einstellungen", though "Optionen" is acceptable too.
Klingon is fine ;)
Contributor
Author
|
@bbbo fixed. LG? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
optionskey to the core translations so the options/settings button has a localized label outside theccnamespace. Part of the UI redesign epic.options?: stringto theCoreTranslationsinterface.cc.optionswording for the 5 languages that already had it: de, en, gr, hi, zh.Verification
npm run lint(tsc --noEmit) passes.ERR_REQUIRE_CYCLE_MODULEin esm/iife specs) are unrelated to this change and reproduce onmaster.Ticket
To be linked under the UI redesign epic.
🤖 Generated with Claude Code