feat(cloudwatch): accept log group ARN via logGroupIdentifier#1172
Open
guilhermejsonar wants to merge 1 commit into
Open
feat(cloudwatch): accept log group ARN via logGroupIdentifier#1172guilhermejsonar wants to merge 1 commit into
guilhermejsonar wants to merge 1 commit into
Conversation
DescribeLogStreams, PutLogEvents, GetLogEvents, and FilterLogEvents now accept either logGroupName or logGroupIdentifier. When an ARN is provided, the log-group name is extracted from the :log-group: segment (with trailing :* tolerated). Log-stream identifiers are similarly stripped of the :log-stream: prefix so SDK responses can round-trip cleanly. DescribeLogStreams responses also include a per-stream arn field. Closes floci-io#1164
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CloudWatch Logs APIs that take a log group reference now accept either
logGroupNameorlogGroupIdentifier. When an ARN is provided, thelog-group name is extracted from the
:log-group:segment (trailing:*tolerated). Log-stream identifiers passed as ARNs have their:log-stream:prefix stripped, so SDK responses round-trip cleanly.DescribeLogStreamsresponses now also include a per-streamarnfield,matching real CloudWatch.
Closes #1164
Affected actions:
DescribeLogStreams,PutLogEvents,GetLogEvents,FilterLogEvents.Type of change
feat:)AWS Compatibility
Verified against AWS CLI
aws-cli/2.34.58 Python/3.14.5 Darwin/24.6.0 source/arm64reproducing the failuredescribed in #1164:
aws logs describe-log-streams --log-group-identifier "arn:aws:logs:us-east-1:000000000000:log-group:/aws/rds/instance/mypostgres-dsf/postgresql"returnedResourceNotFoundExceptionChecklist
./mvnw testpasses locallyCloudWatchLogsHandlerTest, 11 tests covering ARN, ARN+wildcard, plain name, mixed identifier/name precedence, and per-stream ARN response field)