Added multipart data process for PUT, PATCH, DELETE methods#628
Closed
KnifeLemon wants to merge 1 commit intoflightphp:masterfrom
Closed
Added multipart data process for PUT, PATCH, DELETE methods#628KnifeLemon wants to merge 1 commit intoflightphp:masterfrom
KnifeLemon wants to merge 1 commit intoflightphp:masterfrom
Conversation
Collaborator
|
Hey again! So with this code, you actually added quite a bit of code, and it's not unit tested so all the build steps are failing. One thought I had was that you can actually override your own request locally in your project. Something like: class CustomRequest extends flight\net\Request {
// your custom code to handle pulling the multipart data.
}
// some bootstrap code
Flight::unregister('request');
Flight::register('request', CustomRequest::class);If we include this in the framework, it's got to be unit tested and have 100% coverage and that'll take a bit with all the extra code you put in. |
Contributor
Author
|
I forgot the override! And I will update the code to help you with the unit test Thank you :) |
Collaborator
|
Lemme know if you still want/need to do this after you've tested it out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.