Skip to content

Added multipart data process for PUT, PATCH, DELETE methods#628

Closed
KnifeLemon wants to merge 1 commit intoflightphp:masterfrom
KnifeLemon:master
Closed

Added multipart data process for PUT, PATCH, DELETE methods#628
KnifeLemon wants to merge 1 commit intoflightphp:masterfrom
KnifeLemon:master

Conversation

@KnifeLemon
Copy link
Contributor

No description provided.

@n0nag0n
Copy link
Collaborator

n0nag0n commented Feb 20, 2025

Hey again! So with this code, you actually added quite a bit of code, and it's not unit tested so all the build steps are failing. One thought I had was that you can actually override your own request locally in your project. Something like:

class CustomRequest extends flight\net\Request {
// your custom code to handle pulling the multipart data. 
}


// some bootstrap code

Flight::unregister('request');
Flight::register('request', CustomRequest::class);

If we include this in the framework, it's got to be unit tested and have 100% coverage and that'll take a bit with all the extra code you put in.

@KnifeLemon
Copy link
Contributor Author

I forgot the override!
I'll use it as override in the project

And I will update the code to help you with the unit test

Thank you :)

@n0nag0n n0nag0n closed this May 2, 2025
@n0nag0n
Copy link
Collaborator

n0nag0n commented May 2, 2025

Lemme know if you still want/need to do this after you've tested it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants