Skip to content

Simplify Flight and faster performance #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n0nag0n merged 2 commits into from
Feb 16, 2025
Merged

Simplify Flight and faster performance #623

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca7b5b4
Simplify Flight and faster performance
joanhey Feb 14, 2025
78e3a5e
Revert setEngine()
joanhey Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions flight/Flight.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,6 @@ class Flight
/** Framework engine. */
private static Engine $engine;

/** Whether or not the app has been initialized. */
private static bool $initialized = false;

/**
* Don't allow object instantiation
*
Expand Down Expand Up @@ -127,14 +124,7 @@ public static function __callStatic(string $name, array $params)
/** @return Engine Application instance */
public static function app(): Engine
{
if (!self::$initialized) {
require_once __DIR__ . '/autoload.php';

self::setEngine(new Engine());
self::$initialized = true;
}

return self::$engine;
return self::$engine ?? self::$engine = new Engine();
}

/**
Expand Down