Review ewoud#90
Open
ewoudwerkman wants to merge 70 commits into
Open
Conversation
…s name of the spec
added that a self signed certificate can only be used when a public PKI is impossible
…y-considerations Security considerations integration
…ioning-to-s2-connect
…ion dropdown menu
…-to-s2-connect Add versioning to s2 connect
…imit Described per node rate limit for pairing attempts
…election Moved API version selection to its own section
Co-authored-by: Jorrit Nutma <jorrit.nutma@tno.nl>
Updated the challenge response function to mitigate WAN mitm-attacks
Co-authored-by: Jorrit Nutma <jorrit.nutma@tno.nl>
Specified all LAN-LAN pre-pairing interaction
Co-authored-by: Jorrit Nutma <jorrit.nutma@tno.nl>
Added specification for the WAN pairing endpoint registry
…xplenation TXT record
…o its not specific for websockets
…and not LAN clients)
Several smaller impromevents of the S2 Connect specification
…om/flexiblepower/s2-documentation into tls-certificate-check-improvements
DNS-SD improvements
Co-authored-by: Jorrit Nutma <jorrit.nutma@tno.nl>
…ificate-check-improvements
…e-check-improvements Add certificate check and remove mentions of local server checks
Used HTTPS consistently instead of HTTP
Co-authored-by: Jorrit Nutma <jorrit.nutma@tno.nl>
Added subnet check to LAN-LAN only REST operations
Fixed typo Co-authored-by: Jorrit Nutma <jorrit.nutma@tno.nl>
Introduced the term Pairing URL and specified it more clearly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Textual improvements and some comments with
that need to be reviewed.