Skip to content

New/hardware#3

Open
terminet85 wants to merge 5 commits into
flavio:masterfrom
terminet85:new/hardware
Open

New/hardware#3
terminet85 wants to merge 5 commits into
flavio:masterfrom
terminet85:new/hardware

Conversation

@terminet85

Copy link
Copy Markdown

This is enable the support for new scsgate hardware (wireless version)

terminet added 5 commits February 5, 2017 04:42
 Sul branch new/hardware
 Your branch is up-to-date with 'origin/new/hardware'.

 Changes to be committed:
	modified:   Changelog
 Sul branch new/hardware
 Your branch is up-to-date with 'origin/new/hardware'.

 Changes to be committed:
	modified:   scsgate/tasks.py
@flavio

flavio commented Jun 23, 2018

Copy link
Copy Markdown
Owner

Hi, thanks for your contribution! I want to merge support of the ESP based hardware into the library, but I think this PR needs some adjustments.

I'll provide you feedback in the next days.

@flavio flavio left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've more comments coming, in the meantime can you address this request and rebase the PR against master? I just fixed Travis CI to ignore failures on python nightly (apparently the installation of one of the dependencies is broken) and I've added flake8 to the list of tests to perform.

Comment thread Changelog
* Initial release 0.1.0
Sun Feb 05 04:55:23 CET 2017 Emanuele Leuzzi <emanuele@leuzzi.me>
* Release 0.1.1
* Release 0.1.0 (Inizial by Flavio Castelli <flavio@castelli.name>)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop this change, I'll take care of updating the changelog once this is over. The release version is probably going to be different (I think 0.2.0), plus the format is wrong (you should not change existing entries of the changelog, just keep adding the new stuff on the top of it).

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please feel free to make whatever changes you want. I'm not a coder. I committed this 'cause many people asked me this by email. Sorry if I made mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants