Skip to content

chore: p3 cleanup — stale TODOs, boilerplate, package meta#204

Merged
flaglint merged 2 commits into
mainfrom
chore/p3-cleanup-todos-meta
Jul 5, 2026
Merged

chore: p3 cleanup — stale TODOs, boilerplate, package meta#204
flaglint merged 2 commits into
mainfrom
chore/p3-cleanup-todos-meta

Conversation

@Krishan27

Copy link
Copy Markdown
Collaborator

Changes

Boilerplate reduction

  • Added startSpinner(text) to shared.ts — creates spinner, wires SIGINT → exit 130, returns the spinner
  • All 4 commands (scan, migrate, validate, audit) replaced their identical 2-line createSpinner().start() + process.once("SIGINT", ...) block with a single startSpinner() call

Stale TODO removal

  • config.ts — removed TODO v0.3: replace minFileCount with git log (git-based staleness is a post-v1 item, not tracked here)
  • scanner/index.ts — replaced bulk-inventory TODO with a factual note: enforcement already exists in the migrator (safelyAutomatable: false, manualReviewReason: "bulk-inventory-call")

pLimit documentation

  • Added a 2-line comment above pLimit(50) explaining the concurrency choice and its CPU vs I/O trade-off

package.json

  • author: "flaglint"{ name, email, url } object (npm ecosystem standard)
  • keywords: added feature-toggle, flag-cleanup, tech-debt

Test plan

  • 528/528 tests pass locally

- Extract startSpinner() to shared.ts: wires SIGINT → exit 130 and starts
  the spinner in one call; removes the identical 2-line block from all 4
  commands (scan, migrate, validate, audit)
- Remove stale TODO v0.3 from config.ts (git-based staleness is a v2 item)
- Replace bulk-inventory TODO in scanner/index.ts with a note pointing to
  the existing migrator enforcement (safelyAutomatable: false)
- Add 2-line comment above pLimit(50) explaining the concurrency choice
- package.json: author → name/email/url object; add feature-toggle,
  flag-cleanup, tech-debt keywords

Signed-off-by: Krishan Kant Sharma <krishansharma0327@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Krishan27, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 384ddbf4-d521-4b27-b768-755390e4b44c

📥 Commits

Reviewing files that changed from the base of the PR and between 28fa0c1 and dbb3ad7.

📒 Files selected for processing (8)
  • package.json
  • src/commands/audit.ts
  • src/commands/migrate.ts
  • src/commands/scan.ts
  • src/commands/shared.ts
  • src/commands/validate.ts
  • src/config.ts
  • src/scanner/index.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/p3-cleanup-todos-meta

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Krishan Kant Sharma <krishansharma0327@gmail.com>
@flaglint flaglint merged commit 4ef913f into main Jul 5, 2026
8 checks passed
@flaglint flaglint deleted the chore/p3-cleanup-todos-meta branch July 5, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants