docs: v1.0.0 docs audit — fix links, stale outputs, and missing options#185
Conversation
Fix every issue found in the full docs site audit: - Fix 5 broken /guides/ links → /docs/guides/ in audit.md, migrate.md, validate.md, quickstart.md, and blog/launchdarkly-flag-debt.md - Fix 23 wrong GitHub edit-page links (docs-src/content/docs/cli → docs-src/content/docs/docs/cli etc.) across all CLI, concept, guide, tutorial, reference, and integration pages - Remove .flaglintrc.yaml from FAQ — YAML config is not supported (JSON only) - Fix json-output.md: scan does not have --write-baseline; only audit does - Fix blog argument-order post: remove `if: always()` from validate step in CI snippet - Fix audit.md example output: 13 flags 50/100 10/10 (was 53/100 10 auto/9 manual) - Fix effort-estimate.md example output: 22.8h–43.9h (was 20.8h–40h) - Fix quickstart.md and migrate.md: 20 usages found, 10 manual review (was 19/9) - Fix migrate-a-node-service tutorial: same 20/10 correction - Fix docs/index.md hero text: updated Audit complete line - Fix homepage terminal demo: 50/100, 10 manual review, 22.8h–43.9h - Add --write-baseline to audit.md options table (v1.0.0 feature, was missing) - Add --baseline and --fail-on-new options to validate.md with baseline mode docs - Update validate.md with full options table and exit codes table - Update cli/exit-codes.md with v1.x stable 0/1/2/3 contract (was pre-v1 text) Signed-off-by: Krishan Kant Sharma <krishansharma0327@gmail.com>
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughDocumentation-only update that expands ChangesFlagLint Documentation Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Deploying flaglint with
|
| Latest commit: |
5331c4f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7c90b449.flaglint.pages.dev |
| Branch Preview URL: | https://docs-v1-docs-audit-fixes.flaglint.pages.dev |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs-src/content/docs/blog/launchdarkly-openfeature-argument-order-bug.md (1)
143-143: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winPin the CLI version in the CI example.
@latestmakes the workflow drift over time and can change behavior without a docs update. Pin the version you validated, or note explicitly that this example intentionally floats on the latest release.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs-src/content/docs/blog/launchdarkly-openfeature-argument-order-bug.md` at line 143, The npx command in the CI example uses `@latest` for the flaglint package version, which can cause unpredictable behavior changes over time. Either replace `@latest` with a specific pinned version number that you have validated (e.g., `@1.2.3`), or add an explicit note in the documentation explaining that this example intentionally floats on the latest release and the reasons for doing so.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs-src/content/docs/docs/cli/exit-codes.md`:
- Around line 15-16: The exit code 1 row currently mixes failure modes from both
validate and migrate commands, including the --allow-dirty flag which only
applies to migrate. Remove the dirty working tree condition (the part mentioning
--allow-dirty) from the exit code 1 row for validate, keeping only the
validate-specific failures like policy validation and --fail-on-new findings.
Then add the dirty working tree condition to the appropriate exit code row that
documents migrate command failures.
In `@docs-src/pages/index.astro`:
- Around line 915-918: Update the terminal demo output in the index.astro file
to match the actual CLI output terminology. Change the shortened labels
"Readiness:" to match the CLI output's "Migration readiness:" label, and ensure
the effort estimate labels are consistent with what the actual audit command
outputs. Apply this correction to both instances mentioned (around lines 915-918
and line 928) so the homepage demo accurately reflects the real binary output.
---
Nitpick comments:
In `@docs-src/content/docs/blog/launchdarkly-openfeature-argument-order-bug.md`:
- Line 143: The npx command in the CI example uses `@latest` for the flaglint
package version, which can cause unpredictable behavior changes over time.
Either replace `@latest` with a specific pinned version number that you have
validated (e.g., `@1.2.3`), or add an explicit note in the documentation
explaining that this example intentionally floats on the latest release and the
reasons for doing so.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4f7e6503-379a-49d6-8c91-bab543ab8044
📒 Files selected for processing (37)
docs-src/content/docs/blog/launchdarkly-flag-debt.mddocs-src/content/docs/blog/launchdarkly-openfeature-argument-order-bug.mddocs-src/content/docs/docs/cli/audit.mddocs-src/content/docs/docs/cli/configuration.mddocs-src/content/docs/docs/cli/effort-estimate.mddocs-src/content/docs/docs/cli/exit-codes.mddocs-src/content/docs/docs/cli/migrate.mddocs-src/content/docs/docs/cli/report-formats.mddocs-src/content/docs/docs/cli/scan.mddocs-src/content/docs/docs/cli/validate.mddocs-src/content/docs/docs/concepts/how-flaglint-works.mddocs-src/content/docs/docs/concepts/openfeature-boundary.mddocs-src/content/docs/docs/concepts/source-level-debt-signals.mddocs-src/content/docs/docs/enterprise-demo.mddocs-src/content/docs/docs/guides/express.mddocs-src/content/docs/docs/guides/manual-review-patterns.mddocs-src/content/docs/docs/guides/monorepos.mddocs-src/content/docs/docs/guides/nestjs.mddocs-src/content/docs/docs/guides/troubleshooting.mddocs-src/content/docs/docs/index.mddocs-src/content/docs/docs/integrations/github-actions.mddocs-src/content/docs/docs/integrations/openfeature-provider.mddocs-src/content/docs/docs/integrations/opentelemetry.mddocs-src/content/docs/docs/quickstart.mddocs-src/content/docs/docs/reference/changelog.mddocs-src/content/docs/docs/reference/exit-codes.mddocs-src/content/docs/docs/reference/faq.mddocs-src/content/docs/docs/reference/json-output.mddocs-src/content/docs/docs/reference/limitations.mddocs-src/content/docs/docs/reference/supported-scope.mddocs-src/content/docs/docs/trust/security.mddocs-src/content/docs/docs/tutorials/add-openfeature-provider.mddocs-src/content/docs/docs/tutorials/enforce-in-github-actions.mddocs-src/content/docs/docs/tutorials/migrate-a-node-service.mddocs-src/content/docs/docs/tutorials/shared-client-architecture.mddocs-src/content/docs/docs/why-flaglint.mddocs-src/pages/index.astro
Summary
Full audit of all FlagLint documentation against the v1.0.0 binary. Every CLI command shown in docs was run against the built binary; output was compared to what the docs claim.
Broken internal links fixed
/guides/launchdarkly-to-openfeature-nodejs/(missing/docs/prefix) — now corrected inaudit.md,migrate.md,validate.md,quickstart.md, andblog/launchdarkly-flag-debt.mddocs-src/content/docs/cli/instead ofdocs-src/content/docs/docs/cli/etc.) — fixed across all CLI, concept, guide, tutorial, reference, and integration pagesStale CLI output fixed
audit.md,effort-estimate.md,quickstart.md,docs/index.md, homepage terminal demo: corrected from53/100 · 10/9to50/100 · 10/10and effort from20.8h–40hto22.8h–43.9h(verified against actual binary output)migrate.md,quickstart.md,tutorials/migrate-a-node-service.md: corrected fromLaunchDarkly usages found: 19 · Manual review: 9 · Skipped: 9to20 · 10 · 10False feature claims removed
.flaglintrc.yamlis supported — YAML config is not built; corrected to JSON-onlyjson-output.mdclaimedflaglint scan --write-baselineexists —--write-baselineis only onaudit; correctedv1.0.0 missing features documented
audit.mdoptions table: added missing--write-baseline <file>optionvalidate.md: completely rewritten to document--baselineand--fail-on-newoptions, add full options table, baseline mode workflow, and per-command exit codes tablecli/exit-codes.md: updated from pre-v1 vague text to the stable v1.x 0/1/2/3 contractCI YAML bug fixed
blog/launchdarkly-openfeature-argument-order-bug.md: removedif: always()from the validate step (it belonged only on SARIF upload steps, not on the policy gate itself)Test plan
node dist/bin/flaglint.jsoutput from built v1.0.0 binarySummary by CodeRabbit
--write-baseline,--baseline, and--fail-on-new..flaglintrc.jsonorflaglint.config.json) and baseline file provenance.