feat(core): add stable finding fingerprints to scanner output#161
Conversation
Implements ADR 007. Adds fingerprint: string to FlagUsage using schema: launchdarkly:callType:flagKey:normalizedFilePath Fingerprints are stable across line-number changes. Dynamic keys get a sequential index. Part of the v1.0.0 milestone. Signed-off-by: Krishan Kant Sharma <krishansharma0327@gmail.com>
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughIntroduces a ChangesStable FlagUsage fingerprint
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Deploying flaglint with
|
| Latest commit: |
62ff881
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fb7cb522.flaglint.pages.dev |
| Branch Preview URL: | https://feat-stable-fingerprints.flaglint.pages.dev |
Summary
FlagUsagefingerprint: stringfield toFlagUsageusing schemalaunchdarkly:callType:flagKey:normalizedFilePathChanges
src/scanner/fingerprint.tswithgenerateFingerprint()functionsrc/types.ts:FlagUsage.fingerprintadded as required fieldsrc/scanner/index.ts: all 7 FlagUsage construction sites now populatefingerprintsrc/migrator/index.ts: legacy inventory path now generates fingerprintfingerprintsrc/scanner/tests/fingerprint.test.tsTest plan
npm test— all 470 tests pass (441 original + 7 new fingerprint tests + 22 test file count)npm run typecheck— passes cleanlySummary by CodeRabbit
New Features
Tests