Skip to content

Update certifi minimum to 2026.10.19 in TiDB connector example - #80

Open
fivetran-allisonrochelle wants to merge 1 commit into
mainfrom
Update-certifi-minimum-to-2026.10.19
Open

fivetran-allisonrochelle wants to merge 1 commit into
mainfrom
Update-certifi-minimum-to-2026.10.19

Conversation

@fivetran-allisonrochelle

@fivetran-allisonrochelle fivetran-allisonrochelle commented Oct 21, 2026 •

Copy link
Copy Markdown

Description

Update the certifi minimum from 2025.8.3 to 2026.10.19 in both tidb/requirements.txt and the README setup example. Certifi 2026.10.18 removed all emSign roots after eight eMudhra intermediate CA keys were compromised; 2026.10.19 restores unaffected emSign roots while keeping the compromised chain out of the bundle. See GHSA-6q48-6c7w-9gw2.

Validation

  • Confirmed both files specify certifi>=2026.10.19.
  • git diff --check passes.
  • No connector code changed; no fivetran debug run was needed for this repository-maintenance change.

Checklist

  • All contributions: Confirmed that the change and validation evidence contain no credentials, personal data, customer information, or other sensitive values.

@cla-assistant

cla-assistant Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@cla-assistant

cla-assistant Bot commented Oct 21, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@fivetran-allisonrochelle
fivetran-allisonrochelle marked this pull request as ready for review October 21, 2026 17:56
Copilot AI balanced review requested due to automatic review settings October 21, 2026 17:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrowly scoped dependency updates are consistent, with no unresolved findings.

No open issues 🎉

What changed in this PR

Updates the TiDB connector example’s minimum certifi version to address the cited CA-bundle security advisory.

Changes:

  • Raises the minimum version from 2025.8.3 to 2026.10.19.
  • Keeps the README dependency example aligned; connector code is unchanged.
File Description
tidb/​requirements.txt Raises the certifi minimum version.
tidb/​README.md Updates the documented dependency minimum.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants