-
Notifications
You must be signed in to change notification settings - Fork 51
Add Docker Compose support and upgrade ExifTool to 13.50 #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guinslym
wants to merge
4
commits into
fitstool:main
Choose a base branch
from
guinslym:docker-compose
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7fd3b89
Add Docker Compose support and upgrade ExifTool to 13.50
guinslym a5a52cb
Review of PR #419 following pwinckles's recommendations
guinslym 5770b6d
Remove sample image reference from Docker Compose README example
guinslym a60fe9b
Fix fits.install.platforms linux value having no effect
guinslym File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| .git | ||
| target | ||
| work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,3 +36,6 @@ | |
| /target/ | ||
| /version.properties | ||
| /temp/ | ||
|
|
||
| # Runtime directory for Docker Compose volume mount | ||
| /work/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| services: | ||
| # Build and run FITS from source (no Maven required on host) | ||
| fits: | ||
| build: | ||
| context: . | ||
| dockerfile: docker/Dockerfile-compose | ||
| network: host | ||
| image: fits:latest | ||
| volumes: | ||
| - ./work:/work:z | ||
| # Example: docker compose run --rm fits -i myfile.txt | ||
| entrypoint: ["/opt/fits/fits.sh"] | ||
|
|
||
| # Run unit tests | ||
| test: | ||
| build: | ||
| context: . | ||
| dockerfile: docker/Dockerfile-test | ||
| volumes: | ||
| - .:/fits:z | ||
| - maven-cache:/root/.m2 | ||
| command: mvn clean test | ||
| profiles: | ||
| - test | ||
|
|
||
| volumes: | ||
| maven-cache: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| # Multi-stage Dockerfile that builds FITS from source without requiring | ||
| # Maven on the host. | ||
|
|
||
| # Stage 1: Build with Maven | ||
| FROM docker.io/maven:3-eclipse-temurin-17 AS build | ||
| WORKDIR /src | ||
| COPY . . | ||
| RUN mvn -e -DskipTests -Dfits.install.platforms=linux clean package | ||
|
|
||
| # Stage 2: Runtime image (same as docker/Dockerfile) | ||
| FROM docker.io/eclipse-temurin:17-jre-jammy | ||
|
|
||
| ARG FILE_VERSION=5.43 | ||
| ARG FILE_SHA256=8c8015e91ae0e8d0321d94c78239892ef9dbc70c4ade0008c0e95894abfb1991 | ||
|
|
||
| RUN apt-get update && \ | ||
| apt-get install -yqq \ | ||
| # jpylyzer dependencies | ||
| python3 \ | ||
| python-is-python3 \ | ||
| # exiftool dependencies https://github.com/exiftool/exiftool | ||
| libarchive-zip-perl \ | ||
| libio-compress-perl \ | ||
| libcompress-raw-zlib-perl \ | ||
| libcompress-bzip2-perl \ | ||
| libcompress-raw-bzip2-perl \ | ||
| libio-digest-perl \ | ||
| libdigest-md5-file-perl \ | ||
| libdigest-perl-md5-perl \ | ||
| libdigest-sha-perl \ | ||
| libposix-strptime-perl \ | ||
| libunicode-linebreak-perl\ | ||
| # file dependencies | ||
| make \ | ||
| gcc \ | ||
| # mediainfo dependencies | ||
| libmms0 \ | ||
| libcurl3-gnutls \ | ||
| # FITS | ||
| unzip \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Install file https://github.com/file/file | ||
| RUN cd /var/tmp && \ | ||
| curl -so file-${FILE_VERSION}.tar.gz https://astron.com/pub/file/file-${FILE_VERSION}.tar.gz && \ | ||
| echo "${FILE_SHA256} file-${FILE_VERSION}.tar.gz" | sha256sum --check && \ | ||
| tar xzf file-${FILE_VERSION}.tar.gz && \ | ||
| cd file-${FILE_VERSION} && \ | ||
| ./configure && \ | ||
| make -j4 && \ | ||
| make install && \ | ||
| ldconfig && \ | ||
| cd .. && \ | ||
| rm -rf file-${FILE_VERSION}* | ||
|
|
||
| # Install FITS from build stage | ||
| COPY --from=build /src/target/fits-*.zip /opt/fits.zip | ||
| RUN unzip -q /opt/fits.zip -d /opt/fits && \ | ||
| rm /opt/fits.zip && \ | ||
| mkdir -p /var/log/fits | ||
|
|
||
| WORKDIR /work | ||
|
|
||
| ENTRYPOINT ["/opt/fits/fits.sh"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.