Use exiftool/ImageSize for determining image width and height - #408
Draft
cjcolvar wants to merge 1 commit into
Draft
Use exiftool/ImageSize for determining image width and height#408cjcolvar wants to merge 1 commit into
cjcolvar wants to merge 1 commit into
Conversation
Pyramidal tiffs will report multiple values for exiftool/ImageWidth and exiftool/ImageHeight since FITS calls exiftool with the `-a` option and they have multiple image layers contained within the file. For some files the last reported values could be a layer with different dimensions than the original image which leads to CONFLICT statuses with jhove. exiftool/ImageSize only appears once in the exiftool output and its value matches the output from jhove.
cjcolvar
added a commit
to IU-Libraries-Joint-Development/essi
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Pyramidal tiffs will report multiple values for exiftool/ImageWidth and exiftool/ImageHeight since FITS calls exiftool with the
-aoption and they have multiple image layers contained within the file. For some files the last reported values could be a layer with different dimensions than the original image which leads to CONFLICT statuses with jhove. exiftool/ImageSize only appears once in the exiftool output and its value matches the output from jhove.Test coverage
This PR includes a test file and expected FITS XML output file with integration tests.