Skip to content

CLI compile-po-files - added pattern argument for providing custom path to po files#5351

Open
bschwede wants to merge 1 commit intofisharebest:mainfrom
bschwede:custom_compile-po-files
Open

CLI compile-po-files - added pattern argument for providing custom path to po files#5351
bschwede wants to merge 1 commit intofisharebest:mainfrom
bschwede:custom_compile-po-files

Conversation

@bschwede
Copy link
Copy Markdown

With reference to thread convert mo/po - file to php-file it would be nice if this feature could also be used to prepare custom modules depoyment without having to resort to symbolic links or copy operations :-)

@fisharebest
Copy link
Copy Markdown
Owner

Thanks.

I am thinking about extracting the translations to a separate repository.

So I guess we will need different source/target folders. e.g.

source folder (current) Webtrees::ROOT_DIR . 'resources/lang/*/messages.po'
source folder (future) Webtrees::ROOT_DIR . 'vendor/webtrees/translations/lang/*/messages.po'
target folder: Webtrees::ROOT_DIR . 'resources/lang/*/messages.php'

Greg

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.37%. Comparing base (34dff09) to head (cd513f2).

Files with missing lines Patch % Lines
app/Cli/Commands/CompilePoFiles.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5351      +/-   ##
============================================
- Coverage     35.37%   35.37%   -0.01%     
  Complexity    11196    11196              
============================================
  Files          1166     1166              
  Lines         48031    48033       +2     
============================================
  Hits          16990    16990              
- Misses        31041    31043       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants