Add tests for Services, List Modules, Chart Modules, Autocomplete (#5349)

[boris-unckel]

Summary

This PR fills 23 previously empty test stubs (from commit a813962 "Add minimal test scripts for every class") with 137 new test methods covering core services, list modules, chart modules, and autocomplete request handlers.

All tests use the existing TestCase infrastructure with SQLite in-memory database and demo.ged fixture. No changes to production code.

Scope

Services (67 tests)

File	Tests	Coverage
GedcomImportServiceTest	16	Date parsing, Julian days, name extraction, CONT/CONC, empty fields, media, single record import
SearchServiceTest	12	INDI/FAM/SOUR/REPO/place/media/submitter search, multi-word narrowing, guest vs admin visibility
GedcomExportServiceTest	11	HEAD/TRLR structure, PRIV_HIDE export, XREF sorting, download response, SOUR/GEDC header, CONC wrapping
GedcomServiceTest	12	Canonical tags, latitude/longitude parsing
TreeServiceTest	7	Create, delete, findAll, findByName, title, unique names
RelationshipServiceTest	5	Spouse, parent-child, self-relationship, reverse direction
RomanNumeralsServiceTest	4	18 value pairs bidirectional, uppercase output, zero handling

List Modules (14 tests)

File	Tests	Coverage
IndividualListModuleTest	3	Handle request, show all, empty list
FamilyListModuleTest	2	Handle request, list rendering
SourceListModuleTest	2	Handle request, list rendering
RepositoryListModuleTest	2	Handle request, list rendering
NoteListModuleTest	1	Handle request
MediaListModuleTest	2	Handle request, list rendering
SubmitterListModuleTest	1	Handle request

Chart Modules (10 tests)

File	Tests	Coverage
AncestorsChartModuleTest	3	3 chart styles
CompactTreeChartModuleTest	2	Page + AJAX response
PedigreeChartModuleTest	1	Default style
DescendancyChartModuleTest	1	Default style
FanChartModuleTest	1	Default style
HourglassChartModuleTest	1	Default style

AutoComplete Handlers (5 tests)

File	Tests	Coverage
AutoCompletePlaceTest	2	Match + no match
AutoCompleteSurnameTest	2	Match + no match
AutoCompleteCitationTest	1	Skipped — see note below

Known issue found during testing

AutoCompleteCitationTest::testHandleReturnsJsonForValidSource is marked as skipped. During test development, FamilyFactory::mapper() was observed returning null for families whose members are privacy-restricted, causing a fatal error in the citation autocomplete handler.
This appears to be a pre-existing issue, not introduced by these tests. I can file a separate issue if helpful.

Test data

All tests use the bundled demo.ged fixture via $this->importTree('demo.ged'). No additional test data files are needed.

How to run

vendor/bin/phpunit tests/app/Services/GedcomImportServiceTest.php
vendor/bin/phpunit tests/app/Services/
vendor/bin/phpunit tests/app/Module/IndividualListModuleTest.php
# or run the full suite:
vendor/bin/phpunit

Stats

- 23 files changed, +1656 lines, −51 lines (stub replacements)
- 137 test methods total (136 active + 1 skipped)
- All active tests pass on current main with PHP 8.2+

---

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.81%. Comparing base (34dff09) to head (6173ec1).

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #5350      +/-   ##
============================================
+ Coverage     35.37%   36.81%   +1.44%     
  Complexity    11196    11196              
============================================
  Files          1166     1166              
  Lines         48031    48031              
============================================
+ Hits          16990    17684     +694     
+ Misses        31041    30347     -694     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[fisharebest]

Hi Boris,

I am assuming that this PR was created by an AI coding assistant...

With unit tests, it is best practice for each unit test to test only one class. This is often refered to as the "SUT" - "System under test".

So, when testing the request handlers, we only need to test the request handles. Dependencies (such as SearchService) should be provided as "Test Doubles".

In fact, the design of the code ("Services" as constructor dependencies to the request handlers) was designed to allow exactly this type of separation.

So, could you perhaps ask your AI tool to rewrite the unit tests for the request handlers with this in mind.

The "test double" approach makes it trivially easy to provide different values to the request handler (e.g. no data, etc.) to allow every code path and edge-case value to be covered by the test.

[boris-unckel]

Dear Greg,

Thank you very much for reviewing the tests; this is valuable feedback for me. Yes, this is code from Claude CLI. It was created as a byproduct because I needed a test environment for webtrees. I act as a web administrator for a relative who is involved in genealogy. We’ve both become big fans of the software, each from our own perspectives. I’ll adapt the unit test suite (from which the upstream contribution originated) based on your specific feedback. I still need a little time for the other test suites, but then I’ll publish those as open source as well and, of course, offer them to the upstream project here. My goal is to give developers who implement extensions a way to test them regressively against any stable or latest unstable builds as easily as possible.

Webtrees is a great project, and I have great respect for what has already been achieved.

Best regards,
Boris