-
Notifications
You must be signed in to change notification settings - Fork 98
(feat/agent) Agent threads #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nickscamara
wants to merge
13
commits into
main
Choose a base branch
from
nsc/spark2-threads
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9432d6e
Remember the last agent thread per API key
nickscamara 2d9e4bd
Add thread, mode, effort and Exchange flags to agent
nickscamara 2858ff2
Cover agent threads with tests
nickscamara a8f49c1
Document agent threads in the README
nickscamara 446b152
Test which thread a run continues
nickscamara 5e62ef4
Let a follow-up drop inherited URLs and schema
nickscamara 44adeb0
test(agent): reach the argument checks without a stored key
nickscamara 5202a0e
fix(agent): thread memory identity, keyless self-hosted reads, safe s…
nickscamara ae6786c
test(agent): pin the option order the negated flags depend on
nickscamara a2af23c
test(agent): pin thread identity and the approval-bearing poll
nickscamara 15b8f63
refactor(agent): read the shared urls and schema attributes by type
nickscamara cf6ecb0
fix(agent): take the thread lock on a fresh machine, and read the clo…
nickscamara f11fd12
agent: drop Exchange options and the approval flow
nickscamara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3: The new comment says "None of these cases should reach a network round trip," but the 'leaves URLs and schema unset' test in this same file deliberately passes
--api-url http://127.0.0.1:9to reach a failed request. Drop the claim or reword to "no remote call that would block," since the point of the timeout is to fail a hang, and the localhost refusal is the very round trip the assertion relies on.Prompt for AI agents