Skip to content

Make developer search a lean agent surface - #200

Merged
PhantomInTheWire merged 3 commits into
mainfrom
parity-fixes-v3
Aug 20, 2026
Merged

Make developer search a lean agent surface#200
PhantomInTheWire merged 3 commits into
mainfrom
parity-fixes-v3

Conversation

@PhantomInTheWire

@PhantomInTheWire PhantomInTheWire commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

  • expose passages, result types, repository/source scopes, and repository metadata filters on firecrawl developer
  • type and render citation URLs, license disclosures, and repository/source indexing echoes
  • remove the stale 1,200-character fallback and correct docs that claimed a wire type field
  • tolerate both license disclosure objects and flattened SPDX strings during the API rollout

Audit

Closes the CLI gaps in the completed Firecrawl Developer Search parity audit (/tmp/parity-audit.md), audited against API gateway 7dbe90f8530f and CLI 1.21.1 (bd84b0785577). In particular, this addresses request matrix gaps 1/5, response gaps 6–9, and the CLI sections cited in that audit.

Tests

  • pnpm run format:check
  • pnpm run type-check
  • pnpm run build
  • pnpm test (424 passed)

Summary by cubic

Narrows the CLI to a lean developer search surface and removes REST API pointers from CLI help. Old behavior: accepted dedicated filters and locally cut passages; new behavior: accepts only the query and result count, renders full server-shaped passages with citation URLs and license disclosures, echoes repo/source indexing status, infers kind from the id prefix, includes repos/sources in --json, prints "(no results)" when results is missing or empty, and tolerates missing passages.

Migration

  • Stop using removed flags: --skills-only, --passages, --types, --repos, --sources, --language, --topic, --license, --min-stars, --max-stars, --archived, --fork. Put scoping intent in the query text.
  • If you parsed type, infer the result kind from the id prefix (doc, issue, pull_request, readme).
  • If you consume --json, handle new top-level repos and sources arrays.
  • Accept license as either a disclosure object or a flattened SPDX string.

Written for commit d47ed13. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread src/commands/developer.ts Outdated
@PhantomInTheWire

Copy link
Copy Markdown
Member Author

Cubic review addressed in f672598: readable output now treats a missing results array as empty, with a regression test.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread src/commands/developer.ts
@PhantomInTheWire

Copy link
Copy Markdown
Member Author

Follow-up review assessment: keeping DeveloperSearchResponse.results required is intentional because the API contract guarantees the array. The formatter guard is defensive against malformed/empty transport data; widening the public API type would incorrectly claim that a conforming response may omit results.

@PhantomInTheWire PhantomInTheWire changed the title Expose the full developer search contract in the CLI Make developer search a lean agent surface Aug 20, 2026
@PhantomInTheWire

Copy link
Copy Markdown
Member Author

@cubic-dev-ai review

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 20, 2026

Copy link
Copy Markdown

@cubic-dev-ai review

@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.

Fix all with cubic | Re-trigger cubic

Comment thread src/commands/developer.ts Outdated
Comment thread src/commands/developer.ts Outdated
Squashed clean over main: removes all filter flags (types, repos,
sources, language, topic, license, min/max stars, archived, fork,
skills, passages); keeps server-shaped passages, citations, license
rendering, kind-from-id-prefix, and index-status echoes. Resolves
review: results typed optional, id access guarded, empty status
sections render no heading. No REST-API pointers in help text.
@PhantomInTheWire

Copy link
Copy Markdown
Member Author

@cubic-dev-ai review

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 20, 2026

Copy link
Copy Markdown

@cubic-dev-ai review

@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread src/commands/developer.ts Outdated
@PhantomInTheWire

Copy link
Copy Markdown
Member Author

@cubic-dev-ai review

@cubic-dev-ai

cubic-dev-ai Bot commented Aug 20, 2026

Copy link
Copy Markdown

@cubic-dev-ai review

@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Re-trigger cubic

@PhantomInTheWire
PhantomInTheWire merged commit c1ac99f into main Aug 20, 2026
8 checks passed
@PhantomInTheWire
PhantomInTheWire deleted the parity-fixes-v3 branch August 20, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant