Make developer search a lean agent surface - #200
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
Cubic review addressed in |
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
Follow-up review assessment: keeping |
|
@cubic-dev-ai review |
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Fix all with cubic | Re-trigger cubic
Squashed clean over main: removes all filter flags (types, repos, sources, language, topic, license, min/max stars, archived, fork, skills, passages); keeps server-shaped passages, citations, license rendering, kind-from-id-prefix, and index-status echoes. Resolves review: results typed optional, id access guarded, empty status sections render no heading. No REST-API pointers in help text.
|
@cubic-dev-ai review |
738af3f to
45d4821
Compare
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai review |
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
Summary
firecrawl developertypefieldAudit
Closes the CLI gaps in the completed Firecrawl Developer Search parity audit (
/tmp/parity-audit.md), audited against API gateway7dbe90f8530fand CLI 1.21.1 (bd84b0785577). In particular, this addresses request matrix gaps 1/5, response gaps 6–9, and the CLI sections cited in that audit.Tests
pnpm run format:checkpnpm run type-checkpnpm run buildpnpm test(424 passed)Summary by cubic
Narrows the CLI to a lean developer search surface and removes REST API pointers from CLI help. Old behavior: accepted dedicated filters and locally cut passages; new behavior: accepts only the query and result count, renders full server-shaped passages with citation URLs and license disclosures, echoes repo/source indexing status, infers kind from the
idprefix, includesrepos/sourcesin--json, prints "(no results)" whenresultsis missing or empty, and tolerates missingpassages.Migration
--skills-only,--passages,--types,--repos,--sources,--language,--topic,--license,--min-stars,--max-stars,--archived,--fork. Put scoping intent in the query text.type, infer the result kind from theidprefix (doc,issue,pull_request,readme).--json, handle new top-levelreposandsourcesarrays.licenseas either a disclosure object or a flattened SPDX string.Written for commit d47ed13. Summary will update on new commits.