fix: derive artifact kind from the id prefix - #198
Merged
Conversation
The developer-search wire carries no type field; the kind is encoded in the id prefix (doc:, issue:, pull_request:, readme:). The old item.type read matched nothing and the kind label silently never rendered.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wire carries no
typefield (verified against live production — the kind is theidprefix), so theitem.typeread never matched and the kind label silently never rendered. Derives it from the prefix instead, allowlisted to the four real kinds.Aligned with today's docs (firecrawl-docs#1291) and blog fix.
Summary by cubic
Renders the artifact kind label in developer search results by deriving it from the
idprefix. Previously we readitem.type(not present on the wire), so the label never showed.doc,issue,pull_request,readme; unknown prefixes omit the label.src/commands/developer.ts; no API changes or migrations.Written for commit a282a62. Summary will update on new commits.