Skip to content

Add script for converting ode2cellml - #162

Open
finsberg wants to merge 6 commits into
mainfrom
ode2cellml
Open

Add script for converting ode2cellml#162
finsberg wants to merge 6 commits into
mainfrom
ode2cellml

Conversation

@finsberg

@finsberg finsberg commented Jan 22, 2025

Copy link
Copy Markdown
Owner

Add script for converting .ode to .cellml and verify the round trip (e.g .ode -> .cellml -> .ode -> .cellml) produces the same files. Use myokit as adapter.

Also fix and issue with float values becoming evaluated by sympy for example the expression

(v - 4.823)/51.12

will silently be turned into

0.0195618153364632*v - 0.0943466353677621

Now, the full expression is carried through the code generation which will hopefully improve the precision

@finsberg
finsberg marked this pull request as draft January 22, 2025 21:38
@codspeed-hq

codspeed-hq Bot commented Jan 22, 2025

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 8 untouched benchmarks


Comparing ode2cellml (5b01107) with main (0f69a2d)

Open in CodSpeed

@finsberg
finsberg marked this pull request as ready for review August 12, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant