Update Makefile to allow for paths with spaces in them#33
Open
Piroshky wants to merge 2 commits intofiliparag:masterfrom
Open
Update Makefile to allow for paths with spaces in them#33Piroshky wants to merge 2 commits intofiliparag:masterfrom
Piroshky wants to merge 2 commits intofiliparag:masterfrom
Conversation
When I tried to use the Makefile to download the wiki sources it ended up deleting the directory it was called from, due to the Makefile not being able to handle paths with spaces in them. The fix is to wrap the variables that hold the path in quotes when they are being passed as arguments to commands.
Owner
|
Thanks for opening the pull request. I am sorry for not replying earlier. I noticed that you simplified declaration of I revised spacing fixes you provided so it follows |
filiparag
force-pushed
the
master
branch
5 times, most recently
from
2d3c43b to
dba1b2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried to use the Makefile to download the wiki sources it ended up deleting the
directory it was called from, due to the Makefile not being able to handle paths with
spaces in them.
The fix is to wrap the variables that hold the path in quotes when they are being passed
as arguments to commands.