Skip to content

Conversation

@snadrus
Copy link
Contributor

@snadrus snadrus commented Dec 16, 2025

This renames conflicting pdpv0 tasks. There are no conflicting tables.

It'll run only in pdpv0: main will get (via origin/pdpv0-main) instead a post-renames-only version of PDPv0 changes so that the collisions won't happen. The "IF NOT EXISTS" clauses will enable that new SQL to run smoothly on ex-"origin/pdpv0" nodes.

NOTE: These task renames must match exactly in origin/pdpv0-main even though it will not get this migration.

@snadrus snadrus requested a review from LexLuthr December 16, 2025 22:29
@snadrus snadrus requested a review from a team as a code owner December 16, 2025 22:29
Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LexLuthr
Copy link
Contributor

I think we need to migrate FK and triggers as well.

Copy link
Contributor

@LexLuthr LexLuthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! So, I just found out that I created a new table in main for proving as well. We might not need the table rename.

@snadrus snadrus requested a review from LexLuthr December 18, 2025 15:02
@snadrus snadrus requested a review from rvagg December 29, 2025 16:02
@snadrus snadrus merged commit cb31f16 into pdpv0 Dec 29, 2025
15 checks passed
@snadrus snadrus deleted the pdpv0-sql-mig branch December 29, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants