Repository navigation
Update hiredis to v1.4.1 and require CMake 3.15 - #129
Merged
Merged
Conversation
This was referenced Oct 1, 2026
bigsamich
approved these changes
Oct 2, 2026
wsulli
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use hiredis v1.4.1 (
616f2286ba5503f74ae96e720623fa11dbc690af) instead of the v1.4.0 update in #103. The upstream release includes the nested-reply and map-overflow security fixes.Raise the documented CMake minimum to 3.15, matching hiredis 1.4, and include the MIT notice in
hiredis/ffc.hin the dependency inventory. The adapter API is unchanged.Validation: native Linux build with the exact CMake 3.15.0 release, all 14 current-main CTest cases on private Redis 7.4.2, and a macOS build. Applying this pin to the corrected #111 stack also passes all 107 standalone cases on Linux/C++20/Redis 7.4.2; the Cluster case uses its separate fixture.
@bigsamich this is the focused security-release replacement discussed in #103 and #125, ready for review.