Skip to content

Bump benchmark from 12235e2 to 192ef10 - #102

Merged
derekste merged 4 commits into
mainfrom
dependabot/submodules/benchmark-192ef10
Oct 7, 2026
Merged

derekste merged 4 commits into
mainfrom
dependabot/submodules/benchmark-192ef10

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 15, 2026 •

Copy link
Copy Markdown
Contributor

Bumps benchmark from 12235e2 to 192ef10.

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [benchmark](https://github.com/google/benchmark) from `12235e2` to `192ef10`.
- [Release notes](https://github.com/google/benchmark/releases)
- [Commits](google/benchmark@12235e2...192ef10)

---
updated-dependencies:
- dependency-name: benchmark
  dependency-version: 192ef10025eb2c4cdd392bc502f0c852196baa48
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @github

dependabot Bot commented on behalf of github Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Labels

The following labels could not be found: dependencies. Please create it before Dependabot can add it to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

@derekste derekste added the dependencies Pull requests that update a dependency file label Jul 15, 2026
@derekste

Copy link
Copy Markdown
Member

Resolved: the repository now defines the dependencies label requested by .github/dependabot.yml, and this pull request has been labeled accordingly. Future Dependabot updates can apply the configured label automatically.

@bigsamich

Copy link
Copy Markdown
Contributor

Looks good. 192ef10 is the v1.9.5 release tag (v1.9.0 → v1.9.5, 199 commits).

The default CI job doesn't build the benchmark target, so the green check doesn't cover this bump. I built it locally with -DREDIS_ADAPTER_BENCHMARK=ON -DCMAKE_CXX_STANDARD=20, as in test-and-benchmark.yml:

Upstream now builds the library as C++17 and needs CMake ≥ 3.13, both within our requirements.

It needs a rebase (4 commits behind, and the required check is strict).

Side note: the -DCMAKE_CXX_STANDARD=20 in test-and-benchmark.yml is currently ignored, because CMakeLists.txt sets the standard as a normal variable. That workflow actually builds C++17 (#125).

@derekste

Copy link
Copy Markdown
Member

@bigsamich Thanks for building and running the benchmark target explicitly. The regular build-test result alone doesn't cover this dependency.

After the branch is refreshed, the merge evidence should include REDIS_ADAPTER_BENCHMARK=ON, the test suite, and an actual benchmark invocation. The CMake standard override in #125 also needs correction so a C++20-labeled job really compiles as C++20. Your stack-head run is useful supporting evidence; we still need the required check on the final head.

The fixes above are in progress. I'll post the changed commits and validation before requesting another code review.

@derekste
derekste requested a review from a team as a code owner October 1, 2026 01:05
@derekste

derekste commented Oct 1, 2026

Copy link
Copy Markdown
Member

@bigsamich refreshed this branch against current main and kept benchmark pinned to the reviewed v1.9.5 release (192ef10025eb2c4cdd392bc502f0c852196baa48). The build now honors an explicit CMAKE_CXX_STANDARD, and the benchmark can select a private Redis endpoint with REDIS_ADAPTER_BENCHMARK_PORT.

Validation at 093edf9: native Linux C++20 build, all 14 CTest cases, and an actual benchmark smoke run covering baseline, scalar writes/reads, 256-element list writes/reads, and cache-copy cases against an isolated Redis 7.4.2 fixture. The generated compile flags contain -std=gnu++20. The macOS C++20 build also passes. These short benchmark runs verify execution; they are not a performance comparison.

Ready for another review.

@derekste derekste left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at 093edf9. The benchmark v1.9.5 pin, explicit C++ standard override, and private benchmark-port option look consistent. The current required build-test is green; the PR also records the Linux C++20 build, all 14 CTest cases, and an actual isolated benchmark smoke run for this revision. No critical blocker found. The benchmark execution evidence comes from the posted validation; I did not rerun it in this pass.

@derekste
derekste merged commit 077c6ed into main Oct 7, 2026
4 checks passed
@derekste
derekste deleted the dependabot/submodules/benchmark-192ef10 branch October 7, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants