Repository navigation
Bump benchmark from 12235e2 to 192ef10 - #102
Conversation
Bumps [benchmark](https://github.com/google/benchmark) from `12235e2` to `192ef10`. - [Release notes](https://github.com/google/benchmark/releases) - [Commits](google/benchmark@12235e2...192ef10) --- updated-dependencies: - dependency-name: benchmark dependency-version: 192ef10025eb2c4cdd392bc502f0c852196baa48 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
|
Resolved: the repository now defines the |
|
Looks good. The default CI job doesn't build the benchmark target, so the green check doesn't cover this bump. I built it locally with
Upstream now builds the library as C++17 and needs CMake ≥ 3.13, both within our requirements. It needs a rebase (4 commits behind, and the required check is strict). Side note: the |
|
@bigsamich Thanks for building and running the benchmark target explicitly. The regular build-test result alone doesn't cover this dependency. After the branch is refreshed, the merge evidence should include The fixes above are in progress. I'll post the changed commits and validation before requesting another code review. |
|
@bigsamich refreshed this branch against current Validation at Ready for another review. |
derekste
left a comment
There was a problem hiding this comment.
LGTM at 093edf9. The benchmark v1.9.5 pin, explicit C++ standard override, and private benchmark-port option look consistent. The current required build-test is green; the PR also records the Linux C++20 build, all 14 CTest cases, and an actual isolated benchmark smoke run for this revision. No critical blocker found. The benchmark execution evidence comes from the posted validation; I did not rerun it in this pass.
Bumps benchmark from
12235e2to192ef10.Commits
192ef10version bump to 1.9.5d8db2f9Silence -Wc2y-extensions warning around COUNTER (#2108)aa3ed62pin bazelversion to pre-931fae1brename to avoid gtest warnings5c55f5dclang tidy warnings494a04fBump actions/cache from 5.0.1 to 5.0.2 (#2104)90ebbdeMake the Benchmark class public (#2101)262afc9Bump scipy from 1.16.3 to 1.17.0 in /tools (#2103)a6e0a72Bump numpy from 2.4.0 to 2.4.1 in /tools (#2102)27fc2bfBump pypa/cibuildwheel from 3.3.0 to 3.3.1 (#2100)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)