Repository navigation
Over-allocation in MockRedisAdapter list functions using size_bytes() instead of size() #81
Description
Description
In mock/MockRedisAdapter.hpp:62-64 and 93-95, the list mock functions use data.size_bytes() for the allocation count but allocate elements of type T:
int dataSize = data.size_bytes(); // size in BYTES
new T[dataSize], // allocates dataSize ELEMENTS (each sizeof(T) bytes)This allocates sizeof(T) * size_bytes() total bytes instead of the intended amount.
Additionally, std::vector<T> does not have a .size_bytes() method (line 93), so the vector overload likely won't compile for most types.
Severity
Critical
Suggested Fix
Use data.size() instead of data.size_bytes() for the allocation count.
Activity
Fix thread safety, memory bugs, and error handling across redis-adapter
bigsamich commentedon Sep 30, 2026
Still present on
main, and unchanged through #108/#109/#111 (the mock file is byte-identical). It is worse than described here:addSingleListoverload compiles.std::vector,std::arrayand thespanCpp14.hppspan have nosize_bytes().std::spancompiles, and that one allocatessizeof(T)times too much: 48 bytes for 12.CI never compiles the mock, which is how this went unnoticed; filed as #124.
Validated fix:
const size_t count = data.size(); int dataSize = count * sizeof(T); new T[count]. With it, all six vector/array/span × C++17/C++20 combinations compile and run clean under ASan+UBSan, with exactly 12 bytes allocated.