Repository navigation
Created UNR folder and proto definition. - #109
Merged
Merged
Conversation
bstover74
requested review from
beauremus,
chowington,
d4vebr4cey,
jacob-curley-fnal,
mguzman04,
rneswold and
rnethi1701
August 14, 2026 15:12
Closed
Contributor
Author
|
A little rusty - fixed a few var naming misses - my bad. |
Contributor
Author
|
Fixing validation errors now. |
jacob-curley-fnal
requested changes
Aug 14, 2026
jacob-curley-fnal
left a comment
jacob-curley-fnal
left a comment
Contributor
There was a problem hiding this comment.
It's a good start! Here are some things I'd suggest taking a second look at
Contributor
|
Ah, one other thing! The |
Contributor
Author
|
|
mguzman04
reviewed
Aug 14, 2026
Contributor
Author
|
I need one more approval :) |
mguzman04
approved these changes
Aug 14, 2026
chowington
reviewed
Aug 28, 2026
Comment on lines
+18
to
+25
| message RelationshipInfo { | ||
| string parent_id = 1; | ||
| repeated string child_ids = 2; | ||
| } | ||
|
|
||
| message RelationshipResponse { | ||
| repeated RelationshipInfo relationship_info = 1; | ||
| } |
Contributor
There was a problem hiding this comment.
FYI, looks like the double repeated snuck back in here after a refactor @bstover74
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created UNR folder and proto definition.