Skip to content

Update database and gRPC libraries for release 0.3.5 - #38

Merged
jacob-curley-fnal merged 5 commits into
mainfrom
integrate_latest_db_lib
Oct 5, 2026
Merged

jacob-curley-fnal merged 5 commits into
mainfrom
integrate_latest_db_lib

Conversation

@jacob-curley-fnal

@jacob-curley-fnal jacob-curley-fnal commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Upgrade the internal database and gRPC libraries and adapt the service to their updated interfaces.

Changes

Review notes

  • Confirm deployment supplies the required server port now that Dockerfile no longer sets it. A PR exists in the gitops manifest repo to do this: link

@github-actions

This comment was marked as outdated.

@jacob-curley-fnal
jacob-curley-fnal marked this pull request as draft October 1, 2026 13:57
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

Code Coverage Report - 313 of 372 lines covered ( ⚠️ 84.14%)

logging.rs - 9 of 9 lines covered ( 💎 100.00%)

  :shipit:

main.rs - 43 of 62 lines covered ( ⛔ 69.35%)

  Uncovered lines: ⚠️ 39-40, 42-45, 93-103

services - 255 of 295 lines covered ( ⚠️ 86.44%)

 alarm_groups.rs - 69 of 78 lines covered ( ✅ 88.46%)

   Uncovered lines: ⚠️ 85-87, 90, 107-110, 137

 alarm_timers.rs - 160 of 187 lines covered ( ⚠️ 85.56%)

   Uncovered lines: ⚠️ 41, 59, 100, 123-126, 136-139, 151-154, 164-167, 276-277, 303, 312-314

 user_layouts.rs - 26 of 30 lines covered ( ⚠️ 86.67%)

   Uncovered lines: ⚠️ 65-68

 alarm_groups - Directory excluded from coverage report

  queries.rs - Excluded from coverage report

    Excluded based on your `include_pattern` and `exclude_pattern` settings.

  tests.rs - Excluded from coverage report

    Excluded based on your `include_pattern` and `exclude_pattern` settings.

 alarm_timers - Directory excluded from coverage report

  queries.rs - Excluded from coverage report

    Excluded based on your `include_pattern` and `exclude_pattern` settings.

  tests.rs - Excluded from coverage report

    Excluded based on your `include_pattern` and `exclude_pattern` settings.

 user_layouts - Directory excluded from coverage report

  queries.rs - Excluded from coverage report

    Excluded based on your `include_pattern` and `exclude_pattern` settings.

  tests.rs - Excluded from coverage report

    Excluded based on your `include_pattern` and `exclude_pattern` settings.

utils.rs - 6 of 6 lines covered ( 💎 100.00%)

  :shipit:

logging - Directory excluded from coverage report

 tests.rs - Excluded from coverage report

   Excluded based on your `include_pattern` and `exclude_pattern` settings.

proto.rs - Excluded from coverage report

  Excluded based on your `include_pattern` and `exclude_pattern` settings.

services.rs - Excluded from coverage report

  Excluded based on your `include_pattern` and `exclude_pattern` settings.

tests.rs - Excluded from coverage report

  Excluded based on your `include_pattern` and `exclude_pattern` settings.

@jacob-curley-fnal
jacob-curley-fnal marked this pull request as ready for review October 2, 2026 20:51

@chowington chowington left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice reduction of boilerplate! Just one comment, but nothing blocking 👍

Comment thread Dockerfile
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

Code Coverage Report - 313 of 372 lines covered ( ⚠️ 84.14%)

logging.rs - 9 of 9 lines covered ( 💎 100.00%)

  :shipit:

main.rs - 43 of 62 lines covered ( ⛔ 69.35%)

  Uncovered lines: ⚠️ 39-40, 42-45, 93-103

services - 255 of 295 lines covered ( ⚠️ 86.44%)

 alarm_groups.rs - 69 of 78 lines covered ( ✅ 88.46%)

   Uncovered lines: ⚠️ 85-87, 90, 107-110, 137

 alarm_timers.rs - 160 of 187 lines covered ( ⚠️ 85.56%)

   Uncovered lines: ⚠️ 41, 59, 100, 123-126, 136-139, 151-154, 164-167, 276-277, 303, 312-314

 user_layouts.rs - 26 of 30 lines covered ( ⚠️ 86.67%)

   Uncovered lines: ⚠️ 65-68

 alarm_groups - Directory excluded from coverage report

  queries.rs - Excluded from coverage report

    Excluded based on your `include_pattern` and `exclude_pattern` settings.

  tests.rs - Excluded from coverage report

    Excluded based on your `include_pattern` and `exclude_pattern` settings.

 alarm_timers - Directory excluded from coverage report

  queries.rs - Excluded from coverage report

    Excluded based on your `include_pattern` and `exclude_pattern` settings.

  tests.rs - Excluded from coverage report

    Excluded based on your `include_pattern` and `exclude_pattern` settings.

 user_layouts - Directory excluded from coverage report

  queries.rs - Excluded from coverage report

    Excluded based on your `include_pattern` and `exclude_pattern` settings.

  tests.rs - Excluded from coverage report

    Excluded based on your `include_pattern` and `exclude_pattern` settings.

utils.rs - 6 of 6 lines covered ( 💎 100.00%)

  :shipit:

logging - Directory excluded from coverage report

 tests.rs - Excluded from coverage report

   Excluded based on your `include_pattern` and `exclude_pattern` settings.

proto.rs - Excluded from coverage report

  Excluded based on your `include_pattern` and `exclude_pattern` settings.

services.rs - Excluded from coverage report

  Excluded based on your `include_pattern` and `exclude_pattern` settings.

tests.rs - Excluded from coverage report

  Excluded based on your `include_pattern` and `exclude_pattern` settings.

@jacob-curley-fnal
jacob-curley-fnal merged commit 7377a13 into main Oct 5, 2026
1 check passed
@jacob-curley-fnal
jacob-curley-fnal deleted the integrate_latest_db_lib branch October 5, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants