Skip to content

Correct order of Providers - #142

Merged
rneswold merged 3 commits into
mainfrom
PR
Sep 2, 2026
Merged

rneswold merged 3 commits into
mainfrom
PR

Conversation

@rneswold

@rneswold rneswold commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Now the scaffolding takes the form:

_GlobalStateProvider -> AuthService -> providers -> Scaffold

because the providers need the JWT to make mutable queries.

The GraphQL providers need the JWT for settings and other mutating
requests so the `AuthService` widget needs to be wihger in the 
widget tree.
@rneswold
rneswold requested a review from a team September 1, 2026 20:35
@rneswold rneswold linked an issue Sep 1, 2026 that may be closed by this pull request
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Code Coverage Report - 121 of 355 lines covered ( ⛔ 34.08%)

lib - 121 of 355 lines covered ( ⛔ 34.08%)

lib/flutter_controls_core.dart - 0 of 8 lines covered ( ⛔ 0.00%)

⛔ This file is missing coverage.

lib/src - 121 of 347 lines covered ( ⛔ 34.87%)

lib/src/app_scaffold.dart - 37 of 154 lines covered ( ⛔ 24.03%)

Uncovered lines: ⚠️ 18, 36-37, 46, 51, 56, 58, 61-62, 64, 66-67, 69, 74, 78, 80, 82, 84, 92, 94-95, 97, 99, 101, 103, 105, 107-108, 110, 114, 116-117, 124, 129-130, 132-134, 136, 138-139, 144, 152-153, 155, 157-158, 160, 169, 171-172, 178, 180-181, 184, 186-187, 190, 192, 194, 196-199, 207, 214-215, 217-219, 221, 223, 225, 228, 230, 241-243, 247, 249, 251-253, 255, 264-269, 277, 279, 281-282, 284-290, 292, 296-297, 299-300, 302-303, 307, 310, 324, 422, 455, 541, 547, 551, 553

lib/src/fermi_theme.dart - 0 of 66 lines covered ( ⛔ 0.00%)

⛔ This file is missing coverage.

lib/src/otel_tracing.dart - 23 of 44 lines covered ( ⛔ 52.27%)

Uncovered lines: ⚠️ 72-81, 103-104, 111, 117, 119, 194, 196, 198, 203, 205-206

lib/src/widgets - 61 of 83 lines covered ( ⛔ 73.49%)

lib/src/widgets/param_panel.dart - 12 of 12 lines covered ( 💎 100.00%)

:shipit:

lib/src/widgets/param_row.dart - 49 of 71 lines covered ( ⛔ 69.01%)

Uncovered lines: ⚠️ 69, 71-72, 76-77, 79-83, 85, 91-92, 96-97, 99-100, 122, 136-138, 146

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Code Coverage Report - 121 of 355 lines covered ( ⛔ 34.08%)

lib - 121 of 355 lines covered ( ⛔ 34.08%)

lib/flutter_controls_core.dart - 0 of 8 lines covered ( ⛔ 0.00%)

⛔ This file is missing coverage.

lib/src - 121 of 347 lines covered ( ⛔ 34.87%)

lib/src/app_scaffold.dart - 37 of 154 lines covered ( ⛔ 24.03%)

Uncovered lines: ⚠️ 18, 36-37, 46, 51, 56, 58, 61-62, 64, 66-67, 69, 74, 78, 80, 82, 84, 92, 94-95, 97, 99, 101, 103, 105, 107-108, 110, 114, 116-117, 124, 129-130, 132-134, 136, 138-139, 144, 152-153, 155, 157-158, 160, 169, 171-172, 178, 180-181, 184, 186-187, 190, 192, 194, 196-199, 207, 214-215, 217-219, 221, 223, 225, 228, 230, 241-243, 247, 249, 251-253, 255, 264-269, 277, 279, 281-282, 284-290, 292, 296-297, 299-300, 302-303, 307, 310, 324, 422, 455, 541, 547, 551, 553

lib/src/fermi_theme.dart - 0 of 66 lines covered ( ⛔ 0.00%)

⛔ This file is missing coverage.

lib/src/otel_tracing.dart - 23 of 44 lines covered ( ⛔ 52.27%)

Uncovered lines: ⚠️ 72-81, 103-104, 111, 117, 119, 194, 196, 198, 203, 205-206

lib/src/widgets - 61 of 83 lines covered ( ⛔ 73.49%)

lib/src/widgets/param_panel.dart - 12 of 12 lines covered ( 💎 100.00%)

:shipit:

lib/src/widgets/param_row.dart - 49 of 71 lines covered ( ⛔ 69.01%)

Uncovered lines: ⚠️ 69, 71-72, 76-77, 79-83, 85, 91-92, 96-97, 99-100, 122, 136-138, 146

@rneswold
rneswold merged commit cd7983f into main Sep 2, 2026
2 checks passed
@rneswold
rneswold deleted the PR branch September 2, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

providers: are mounted above AuthService, so getJwt() returns null

2 participants