fix: compute actual string length in set_owning heap path - #277
Open
a2Fsa2k wants to merge 1 commit into
Open
Conversation
When set_owning(str, len) is called with a len larger than the actual null-terminated length of str, and the allocation falls on the heap path (len > short_length_limit), h_.size_ was set to len rather than the actual string length. This caused size() to report incorrect values for heap strings shorter than their allocated capacity.
Author
|
Note: the CI build failures (in @felixguendling whenever you get a chance to review, the fix addresses the inconsistent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
set_owning(str, len)is called with alenlarger than the actual null-terminated length ofstr, and the allocation falls on the heap path (len > short_length_limit),h_.size_was set to the fulllenrather than the actual string length. This causessize()to report incorrect values.Example:
set_owning("", 32)would reportsize() == 32instead ofsize() == 0on the heap path, inconsistent with the short string path which correctly returns 0.The fix computes the actual string length via
std::char_traits<CharT>::length(str)and usesmin(actual_length, len)forh_.size_.Fixes #190.