Skip to content

[codex] Add Rectangle with window manager conflict handling - #17

Merged
felipe0328 merged 2 commits into
mainfrom
codex/add-rectangle-conflict-handling
Jun 24, 2026
Merged

[codex] Add Rectangle with window manager conflict handling#17
felipe0328 merged 2 commits into
mainfrom
codex/add-rectangle-conflict-handling

Conversation

@felipe0328

Copy link
Copy Markdown
Owner

What changed

  • add Rectangle as an optional Homebrew cask component
  • introduce reusable component conflict metadata and validation
  • warn interactive users who select both Rectangle and AeroSpace, then ask which one to keep
  • reject conflicting non-interactive selections
  • prefer the recommended window manager in --all mode
  • replace a conflicting saved window manager when users switch choices
  • document the Rectangle/AeroSpace relationship

Why

Rectangle and AeroSpace both manage windows and overlapping controls can produce a confusing setup. Users should be able to install Rectangle while receiving clear guidance that the two alternatives should not run together.

Impact

AeroSpace remains selected by default. Rectangle is available in the installer but starts unselected. If both are selected interactively, installation pauses and asks the user which one to keep before making changes.

Validation

  • bash tests/installer_test.sh — 27 tests passed
  • shellcheck -x lib/core.sh lib/ui.sh install.sh sync.sh components/42-rectangle.sh tests/installer_test.sh
  • bash -n lib/core.sh lib/ui.sh install.sh sync.sh components/42-rectangle.sh tests/installer_test.sh
  • git diff --check

@github-actions

Copy link
Copy Markdown
Contributor

Version preview

Current Expected after merge Bump
1.2.1 1.3.0 minor

This PR will trigger a version bump after it is merged into main.

conventional commits require minor bump.

@felipe0328
felipe0328 marked this pull request as ready for review June 24, 2026 16:12

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e7b7eb2d95

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread install.sh Outdated
@felipe0328
felipe0328 merged commit c9bc331 into main Jun 24, 2026
6 checks passed
@felipe0328
felipe0328 deleted the codex/add-rectangle-conflict-handling branch June 24, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant