[codex] Add Rectangle with window manager conflict handling - #17
Merged
Conversation
Contributor
Version preview
This PR will trigger a version bump after it is merged into
|
felipe0328
marked this pull request as ready for review
June 24, 2026 16:12
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7b7eb2d95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
--allmodeWhy
Rectangle and AeroSpace both manage windows and overlapping controls can produce a confusing setup. Users should be able to install Rectangle while receiving clear guidance that the two alternatives should not run together.
Impact
AeroSpace remains selected by default. Rectangle is available in the installer but starts unselected. If both are selected interactively, installation pauses and asks the user which one to keep before making changes.
Validation
bash tests/installer_test.sh— 27 tests passedshellcheck -x lib/core.sh lib/ui.sh install.sh sync.sh components/42-rectangle.sh tests/installer_test.shbash -n lib/core.sh lib/ui.sh install.sh sync.sh components/42-rectangle.sh tests/installer_test.shgit diff --check