Baseline references - handle API variants, symbols and strings - #11
Open
seandenigris wants to merge 1 commit into
Open
Baseline references - handle API variants, symbols and strings#11seandenigris wants to merge 1 commit into
seandenigris wants to merge 1 commit into
Conversation
BaselineOf references view currently misses references that use symbols vs. strings, as well as those that use API variants other than `baseline:with:`.
Originally implemented more simply as 4 gtReferences or-ed together as below, but that was way too slow:
```smalltalk
self gtReferences
| (('`@receiver baseline: ', aName) gtASTMatches)
| (('`@receiver baseline: ', aName asSymbol) gtASTMatches)
| (('`@receiver baseline: ', aName, ' with: `@arg') gtASTMatches)
| (('`@receiver baseline: ', aName asSymbol, ' with: `@arg') gtASTMatches)
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaselineOf references view currently misses references that use symbols vs. strings, as well as those that use API variants other than
baseline:with:.Originally implemented more simply as 4 gtASTMatches or-ed together as below, but that was way too slow for results to appear in the UI: