Open
Conversation
Member
prudhomm
commented
Oct 12, 2018
prudhomm
commented
- Have you checked to ensure there aren't other open Pull Requests for the same change?
- Have you fixed a Bug ?
- Have you added the documentation of the example or benchmark ?
- Have you successfully run the example or benchmark?
- Have you documented the results?
- Have you added the images to the documentation?
- Have you added the vtkjs files for 3D visualization in the documentation?
- Have you added the vtkjs files to a Data Management Plateform e.g https://girder.math.unistra.fr
Member
Author
|
@GQMP it seems it was never really finished. could you add results for some parameters with comments please. Since I made the PR I cannot do the review. @romainhild could you do it ? |
romainhild
approved these changes
Oct 12, 2018
Member
Author
|
but @romainhild the results with analysis are missing in the page |
Contributor
|
oops sorry, I read too fast, I thought you wanted to merge immediately. |
romainhild
suggested changes
Oct 12, 2018
Contributor
romainhild
left a comment
romainhild
left a comment
There was a problem hiding this comment.
could you add results for some parameters with comments please ?
Member
Author
|
I don't want to merge at all cost. There must be certain components available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.