Cbf fix tests#31
Open
randomlogin wants to merge 13 commits into
Open
Conversation
Add stub methods/functions, add basic build and start of the CBF chain source as well as basic struct containing the fields which undoubtedtly are needed.
Previously tests assumed that the chain source of the lightning node and is node which mines. This is not the case with CBF chain source which needs to wait until after mining a new block a new tips propagates to it. `wait_for_block` is made to return a new height and a new function `wait_for_node_tip` is added which waits until the given height is processed (returned via `status.best_block` ) on a given node.
Ask wallet for revealed spks, register them. Implement `Listen` trait ans add register_script method as well as implementation of registered scripts/outputs.
When `process_kyoto_events` processes events it decides whether we need to take any action (e.g. apply block). These actions are sent to a new abstraction — `BlockApplicator` which holds `ChainListener` (which in turn has wallets and can apply blocks / filtered blocks). This `BlockApplicator` has to have a receiver of a channel (and `process_kyoto_events` has to have a sender to this channel. Thus we cannot create them in `new`, because we would own them at `CbfChainSource`, so they are created in `start`. Also this commit ran `cargo fmt --all` which was missed previously.
Co-authored-by: febyeji <yeji.han@sf.snu.ac.kr>
Added 4 variants of `ChainOp`: - ConnectFull, - ConnectFiltered, - Disconnect, - Synced Now `process_kyoto_events` reacts to an event from kyoto and sends a `ChainOp` to listener (`BlockApplicator`). Note that on a filter with no match we still need to apply header and we need double check that header in the canonical chain is the relevant one and has not been reorged. Right now it is left as a todo, because of an upstream PR. Co-authored-by: febyeji <yeji.han@sf.snu.ac.kr>
We implement three fee sources for the CBF chain source. 1) esplora 2) electrum. For electrum we altered the existing code from the electrum chain source to make it reusable for the CBF node We change runtime argument to `start()` to be a field in `CbfChainSource` struct, because electrum fee source explictely needs it. 3) CBF native fee source. It downloads blocks and calculates fees based on previous blocks. We maintain a cache up to `BLOCK_FEE_CACHE_CAPACITY=14` blocks. For confirmation target we use estimation vie percentil of previous blocks' fees. Also if we download a block on a matched block filter, we insert it in the cache to avoid re-downloading. As the block download might be slow, we don't fail the fee estimation, but rather use fallback fees. This is especially relevant to the very first call of `update_fee_rate_estimates` during the start. We add helper pure functions in a new file `src/util.rs`. Co-authored-by: febyeji <yeji.han@sf.snu.ac.kr>
Co-authored-by: febyeji <yeji.han@sf.snu.ac.kr>
Onchain wallet's scripts are pulled each time we receive `IndexedFilter` event. That way we rely on a single source of truth (wallet) instead of having two overlapping script sets. Now we pass a reference to the `onchain_wallet` to make possible get all revealed scripts from it. Co-authored-by: febyeji <yeji.han@sf.snu.ac.kr>
Co-authored-by: febyeji <yeji.han@sf.snu.ac.kr>
Also added env var for the CBF tests, also waiting for tx gossip for broadcast in some of the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
next_heightto block applicator, so in case of kyoto's event repeat we don't reapply them.Started to fix tests, currently failing ones:
For now yet unfinished things:
wait_for_txwhen we know txid, some of the tests fail because of absence of that.FutureOrderedthing is not yet added. And we just remain unsynced if blocks come not in the order (not 100% sure, but it seems this way).