Ability to disable log with level ERROR if key not exists

[roman-struchev]

Context
We use feature hub to manage feature toggles

Also, we have 2 additional point

• not all feature toggles exist in feature hub, the responsible person often creates it when feature toggle is needed
• we have several feature toggle sources with priority, for example, feature hub, application properties, environment, etc

Issue

featurehub-java-sdk/client-java-core/src/main/java/io/featurehub/client/ClientFeatureRepository.java

Lines 247 to 259 in f6fd04b

	public FeatureState getFeatureState(String key) {
	return features.computeIfAbsent(
	key,
	key1 -> {
	if (hasReceivedInitialState) {
	log.error(
	"FeatureHub error: application requesting use of invalid key after initialization: `{}`",
	key1);
	}
	return new FeatureStateBase(null, this, key);
	});
	}

When we try to get feature value in java (io.featurehub.client.ClientFeatureRepository#getFeatureState) first time, then we have such log for our applications FeatureHub error: application requesting use of invalid key after initialization: XXX.

This happens only for the first request for the feature toggle (not existing in feature hub), after instance of application was restarted (because of java.util.Map#computeIfAbsent used)

So in monitoring of our applications we have error cases by logs

Fix
I try to provide an ability to skip this log by configuration, because looks like that is usual case when feature toggle not exists in feature hub

[rvowles]

Hey, probably simpler - it should really allow the feature to exist all the time even if it never comes from the server. I have another change to make so I will simplify this logic and write a test or two to ensure its working properly. Thanks for bringing this to our attention!

[roman-struchev]

Hello @rvowles, do you have an update?

[rvowles]

We are still a way off releasing the new SDK, so I will organise to and merge this into a long lived branch for this version. Sorry for the delay, we have been focusing on the new release with Application Strategies.

[rvowles]

I changed this to a warn but its not what you want so I will keep this and revisit it. I have some more updates to the SDK to make in the next week.