Skip to content

Kip branch#10

Open
kiplingw wants to merge 2 commits intofbb-git:masterfrom
kiplingw:kip-branch
Open

Kip branch#10
kiplingw wants to merge 2 commits intofbb-git:masterfrom
kiplingw:kip-branch

Conversation

@kiplingw
Copy link

@kiplingw kiplingw commented Aug 2, 2017

Patched two compilation errors I experienced with gcc 6.3.0.

…eeds to explicitly invoke the base default constructor or will generate a compiler error with gcc.
@fbb-git
Copy link
Owner

fbb-git commented Aug 12, 2017

Hi Kiplingw,

Thanks for your suggestions. I completely agree with your first patch: std:: before thread_local is an error, and it'll be fixed in the next bisonc++ release.
Wrt your 2nd patch i'm not so sure:

  • polymorphic semantic values have by now been used quite often, and
    so far no compiler error has been encountered, so I'm wondering what
    might have caused your compiler error.

  • You write `required on gcc', but C++ programs are normally compiled
    using g++.

  • In the following small piece of code my compiler (neither g++ nor gcc)
    doesn't generate compilation errors:

struct Base
{
    Base();
};
template <int value>
struct Derived
{
    Derived() = default;
    Derived(Derived<value> const &other);
};
template <int value>
Derived<value>::Derived(Derived<value> const &other)
{}
int main()
{
    Derived<5> d5;
    Derived<5> d5b(d5);
}

So, I'm somewhat in the dark as to what may have caused your compiler error.
I used gcc version 6.4.0, and g++ versions 6.4.0 as well as 7.1.0, and none of
these three compilers reported errors.

Until this issue has been resolved, it's probably best not to process your 2nd patch.
Nonetheless, thanks a lot for your suggestions!

F.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants