fixes for depth_multiplier in SeparableConv2d and DepthwiseConv2d#1008
Open
dgburnette wants to merge 2 commits intomainfrom
Open
fixes for depth_multiplier in SeparableConv2d and DepthwiseConv2d#1008dgburnette wants to merge 2 commits intomainfrom
dgburnette wants to merge 2 commits intomainfrom
Conversation
jmitrevs
reviewed
Jun 11, 2024
| Attribute('in_height'), | ||
| Attribute('in_width'), | ||
| Attribute('out_height'), | ||
| Attribute('out_width'), |
Contributor
There was a problem hiding this comment.
I don't understand why this is removed.
Contributor
|
I think we want to handle this in a different way. We want to split seperable into depthwise followed by pointwise. I will soon make a PR trying to do that. I'll try to add depth multiplier support there. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A# Description
The model python attached (model_asic.py) demonstrated that the shape printed by hls4ml (e.g. [None,32,32,8]) did not agree with the python model.summary() (e.g. [None,32,32,40)).
It turns out to be an incomplete handling of depth_multiplier in the SeparableConv2d and DepthwiseConv2d implementations.
Type of change
For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.
Note: Please delete options that are not relevant.
Tests
Test Configuration:
Checklist
pre-commiton the files I edited or added.