Skip to content

Feature/php 8.5 compatibility#793

Merged
harmony7 merged 3 commits into
fastly:masterfrom
favicode:feature/php-8.5-compatibility
Mar 9, 2026
Merged

Feature/php 8.5 compatibility#793
harmony7 merged 3 commits into
fastly:masterfrom
favicode:feature/php-8.5-compatibility

Conversation

@ivanviduka

Copy link
Copy Markdown
Contributor

No description provided.

@andriyShevtsov

Copy link
Copy Markdown

@ivanviduka please take a look on this issue: #794

I believe it's needed for 8.5 compatibility as well as 8.4

@andriyShevtsov

andriyShevtsov commented Mar 7, 2026

Copy link
Copy Markdown

Any way we can expedite or escalate it? This issue is going to break all redeploys on Tuesday March 10th?

@ivanviduka

Copy link
Copy Markdown
Contributor Author

@andriyShevtsov I do not have a control over release schedule and merging, we only maintain Fastly plugin.

As for the compatibility - this PR was tested with Magento 2.4.9 beta which we were granted access to. After changes in this PR, setup upgrade and switching Magento to production mode commands worked as expected.
Compatibility with 8.4 was tested when Magento 2.4.8 was in beta version and everything worked okay as well. I don't know in which version Magento introduced changes for Symfony Console, but initial version testing for PHP 8.4 didn't cause any problems with said module

@harmony7 harmony7 merged commit 6a4f7b2 into fastly:master Mar 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants