Skip to content

[CDTOOL-1322] Add Support for DNS Zones and TSIG Keys#1809

Merged
rcaril merged 6 commits into
mainfrom
CDTOOL-1322-dns-support
Jun 2, 2026
Merged

[CDTOOL-1322] Add Support for DNS Zones and TSIG Keys#1809
rcaril merged 6 commits into
mainfrom
CDTOOL-1322-dns-support

Conversation

@rcaril

@rcaril rcaril commented Jun 2, 2026

Copy link
Copy Markdown
Member

Change summary

This PR adds support for Fastly DNS Zones and TSIG Keys.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?
 make test TEST_ARGS="-run TestZoneCreate ./pkg/commands/dns/zone"
ok      github.com/fastly/cli/pkg/commands/dns/zone     1.096s
make test TEST_ARGS="-run TestZoneDescribe ./pkg/commands/dns/zone"
ok      github.com/fastly/cli/pkg/commands/dns/zone     1.087s
make test TEST_ARGS="-run TestZoneDelete ./pkg/commands/dns/zone"
ok      github.com/fastly/cli/pkg/commands/dns/zone     1.072s
 make test TEST_ARGS="-run TestZoneList ./pkg/commands/dns/zone"
ok      github.com/fastly/cli/pkg/commands/dns/zone     1.081s
make test TEST_ARGS="-run TestZoneUpdate ./pkg/commands/dns/zone"
ok      github.com/fastly/cli/pkg/commands/dns/zone     1.102s

 make test TEST_ARGS="-run TestTSIGKeyCreate ./pkg/commands/dns/tsigkey"
ok      github.com/fastly/cli/pkg/commands/dns/tsigkey  1.111s
make test TEST_ARGS="-run TestTSIGKeyDescribe ./pkg/commands/dns/tsigkey"
ok      github.com/fastly/cli/pkg/commands/dns/tsigkey  1.081s
 make test TEST_ARGS="-run TestTSIGKeyDelete ./pkg/commands/dns/tsigkey"
ok      github.com/fastly/cli/pkg/commands/dns/tsigkey  1.072s
 make test TEST_ARGS="-run TestTSIGKeyList ./pkg/commands/dns/tsigkey"
ok      github.com/fastly/cli/pkg/commands/dns/tsigkey  1.071s
make test TEST_ARGS="-run TestTSIGKeyUpdate ./pkg/commands/dns/tsigkey"
ok      github.com/fastly/cli/pkg/commands/dns/tsigkey  1.098s

Changes to Core Features:

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

User Impact

None.

@rcaril rcaril marked this pull request as ready for review June 2, 2026 13:25
@rcaril rcaril requested a review from a team as a code owner June 2, 2026 13:25
@rcaril rcaril requested a review from philippschulte June 2, 2026 13:25

@philippschulte philippschulte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Please just double check create/update for zones with --primary-description which requires --primary-address. Thank you!

Comment thread pkg/commands/dns/zone/update.go
@rcaril rcaril merged commit 03b60d5 into main Jun 2, 2026
15 checks passed
@rcaril rcaril deleted the CDTOOL-1322-dns-support branch June 2, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants