SSO warnings: write "session expires in ..." when refresh token is present#1685
Merged
Conversation
…esent When a refresh token is available, prefix expiration warnings with "session" to distinguish refresh-based expiry from access token expiry. Also suppress access-token expiration warnings when a refresh token exists but has no expiry set (it will auto-refresh).
kpfleming
approved these changes
Mar 18, 2026
Member
|
No concerns from me. Most users aren't going to care about the difference between the tokens and their expirations, but when we are assisting users who have reported problems the additional information will be very useful. |
jedisct1
added a commit
that referenced
this pull request
Mar 23, 2026
* main: [CDTOOL-1304] Ensure that the Fastly Auth type commands respect the `--quiet` Flag (#1710) build(deps): bump the go-dependencies group with 2 updates (#1707) [CDTOOL-1102] Add support for the `service vcl snippet describe` `--content` flag (#1706) SSO warnings: write "session expires in ..." when refresh token is present (#1685) # Conflicts: # pkg/app/run.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
When a refresh token is available, prefix expiration warnings with "session" to distinguish refresh-based expiry from access token expiry (e.g. "Your active token session expires in 10 minutes").
Also suppress access-token expiration warnings when a refresh token exists but has no expiry set, since the token will auto-refresh and the warning would be misleading.
All Submissions:
New Feature Submissions:
Changes to Core Features:
User Impact
Clearer expiration warnings: "session expires in ..." instead of "expires in ..."
Are there any considerations that need to be addressed for release?
No breaking changes. This is a cosmetic/UX improvement to warning messages only.