Skip to content

revert: remove top-level move semantics#53

Merged
andylokandy merged 1 commit intomainfrom
revert-top-level-move-semantics
May 4, 2026
Merged

revert: remove top-level move semantics#53
andylokandy merged 1 commit intomainfrom
revert-top-level-move-semantics

Conversation

@andylokandy
Copy link
Copy Markdown
Contributor

Summary

  • Remove the unreleased Exn::into_error() API introduced in feat: top-level move semantics #48.
  • Remove the into-error example that depended on root-only move recovery.
  • Drop the corresponding unreleased changelog entry.

Closes #50.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleanly reverts the unreleased top-level move-recovery API from exn so the crate no longer exposes Exn::into_error() or the example/changelog entries that depended on it. It aligns the codebase with the direction discussed in #50: keeping exn focused on contextual error trees rather than root-only move semantics.

Changes:

  • Remove the unreleased Exn::into_error() method from exn/src/impls.rs.
  • Delete the into-error example and unregister it from examples/Cargo.toml.
  • Remove the matching unreleased changelog entry.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
exn/src/impls.rs Removes the unreleased Exn::into_error() API from the core exception type.
examples/src/into-error.rs Deletes the example that demonstrated the removed move-recovery API.
examples/Cargo.toml Removes the example target so Cargo no longer references the deleted file.
CHANGELOG.md Drops the unreleased changelog note for into_error().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@andylokandy andylokandy merged commit e223542 into main May 4, 2026
16 checks passed
@andylokandy andylokandy deleted the revert-top-level-move-semantics branch May 4, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reconsider top-level move semantics

2 participants