Reload user object after BEFORE_LOGIN/CREATE_USER hooks are run#70
Open
alxbridge wants to merge 2 commits into
Open
Reload user object after BEFORE_LOGIN/CREATE_USER hooks are run#70alxbridge wants to merge 2 commits into
alxbridge wants to merge 2 commits into
Conversation
…user session after authentication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user's
is_activestatus is changed in the configured BEFORE_LOGIN or CREATE_USER functions, this change isn't seen when checkingis_activeto log the user in, so they can be incorrectly granted/denied access based on the stale value. This PR fixes this by reloading the user object before the check.