Rearchitect Updater into a registry
#428
Open
+464
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
…ugin- and theme-specific logic as necessary. Signed-off-by: John Blackbourn <[email protected]>
johnbillion
force-pushed
the
instances
branch
from
23e7bdf to
25bf09e
Compare
afragen
added
enhancement
Contributor
|
@johnbillion how do I setup QM to see the hooks you are seeing? |
afragen
reviewed
Jan 29, 2026
| * @return string|WP_Error | ||
| */ | ||
| public function upgrader_source_selection( string $source, string $remote_source, WP_Upgrader $upgrader, $hook_extra = null ) { | ||
| public static function upgrader_source_selection( string $source, string $remote_source, WP_Upgrader $upgrader, $hook_extra = null ) { |
Contributor
There was a problem hiding this comment.
Shouldn't this have the changes from string $source to $source and the early exit for a WP_Error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427
I've been using this on my local installation for a couple of weeks, although with a fairly limited number of updates. Needs some thorough testing by the FAIR Connect team.
Testing
Testing this requires installing more than one plugin or theme that has a
Plugin ID: did:plc:...header. You can install Pods, Query Monitor, User Switching, and WP Crontrol for testing this. They don't need to be active.Prior to testing you can choose to flush all your transients or not. This change doesn't affect the way transients for updates are stored or handled so it will continue to work with your existing cache.
In order to trigger and test an update check for a plugin or theme, you'll need to clear the appropriate transients.
Items to test:
Before
After