Remove unused arguments and imports#98
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
hoschwenk
left a comment
There was a problem hiding this comment.
Thanks a lot for cleaning up the code !
I would prefer to keep the lower_case flag even though it is currently not used.
Future version of LASER may be case sensitive :-)
This reverts commit 7e1e7cc.
|
Fair enough. Reverted those changes. |
Removed unusedlower_caseargument inTokenandTokenLinelineargument inBPEfastLoadmine_bitexts.pyMOSES_LCintext_processing.pywhich pointed to the no longer used Moses lowercasing script