Fix boolean comparison bug#256
Conversation
|
Hi @vdasu! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
meta-cla
Bot
added
the
CLA Signed
Summary: Fix assignment (`=`) instead of comparison (`==`) in `proto_match` check in `report_lru_miss_stats_for_vip()`. The bug caused `proto_match` to always evaluate to `true` (since protocol values like TCP=6 are non-zero) and silently corrupted the `lru_miss_stat_vip` BPF map entry by overwriting its proto field. Ref: #256 Reviewed By: lima1756 Differential Revision: D103681601 fbshipit-source-id: 257124c598a82d66a5c8f0b30760c5b68f01115f
1 participant
There is a bug in the
bool proto_matchwhere the comparison uses=instead of==.